Fix assignment to nil map in EML parser #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted outdated and redundant EML-related test cases from `eml_test.go`. These tests were either unused, overly specific, or no longer relevant, simplifying the codebase and improving maintainability.
Replaced inline Msg struct initialization with the NewMsg constructor in EMLToMsgFromReader and EMLToMsgFromFile functions. This improves code readability and maintains consistency in Msg struct creation.
This commit introduces a test case ensuring that parsing an EML file and writing the parsed message back to a buffer works as expected. It also includes a sample EML file for testing. This resolves functionality concerns highlighted in issue #446.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
==========================================
- Coverage 94.34% 94.32% -0.02%
==========================================
Files 30 30
Lines 3534 3522 -12
==========================================
- Hits 3334 3322 -12
Misses 147 147
Partials 53 53 ☔ View full report in Codecov by Sentry. |
The SPDX-PackageSupplier was changed to "The go-mail Authors" for consistency. Added annotations for the testdata directory with copyright and license details to improve compliance and clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a nil map assignment in the EML parser. This PR closes #446.