Disable pre_save and post_save signals during loaddata#356
Merged
Conversation
Member
|
What are you trying to do that you hit this? I've actually liked our signal use less and less over the years so it could make sense to take a different route. |
Collaborator
Author
I'm trying to set up fixtures for staging and local environments, but when the signals are active, |
Member
|
Seems like a good fix, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to disable
pre_saveandpost_savesignals when therawkeyword argument isTrue, which is the case when fixtures are being loaded via theloaddataDjango admin command.This makes it overall easier to set up fixtures and seed the database for local development. If the signals are not disabled, every time a fixture for a
ScriptVersionis being loaded, the backend tries to validate the script (which doesn't actually exist as a file on the host).