Add indicator percentpop euclidean proximity to openspace#83
Draft
weiqi-tori wants to merge 14 commits into
Draft
Add indicator percentpop euclidean proximity to openspace#83weiqi-tori wants to merge 14 commits into
weiqi-tori wants to merge 14 commits into
Conversation
…icator-percentpop-euclidean-proximity-to-openspace
…to add-indicator-percentpop-euclidean-proximity-to-openspace
Member
Author
|
Updates:
|
…icator-percentpop-euclidean-proximity-to-openspace
…icator-percentpop-euclidean-proximity-to-openspace
…icator-percentpop-euclidean-proximity-to-openspace
…icator-percentpop-euclidean-proximity-to-openspace
…icator-percentpop-euclidean-proximity-to-openspace
kcartier-wri
requested changes
Feb 11, 2025
Collaborator
There was a problem hiding this comment.
Looks good, but could you please:
-
Simplify the section of code starting with "if bbox.units == "degrees":" utilizing GeoExtent functions on bbox parameter? See cams.py for a partial example. I should have made this change myself, but you might as well address it in this PR.
-
Add a test to https://github.com/wri/cities-cif/blob/main/tests/resources/layer_dumps/test_write_all_layers.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Yes, I have read How to contribute
No, I haven't read it.
Is this PR related to a JIRA ticket?
Yes, the URL of the associated JIRA ticket is https://gfw.atlassian.net/browse/CIF-XXX. The PR name follows the format
[CIF-XXX] my subject.No, this is a documentation update. The PR name follows the format
[DOCS] my subject.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?