[Misc] Moving deprecated Job APIs to legacy #482
Conversation
| --> | ||
|
|
||
| <org.xwiki.job.internal.DefaultJobStatus> | ||
| <org.xwiki.job.DefaultJobStatus> |
There was a problem hiding this comment.
I had to modify the serialization in the XML files of the test, since the class is not present anymore in this module. I don't think it would have an impact for real world status serialization if the old class is available through the legacy module.
| boolean ignore = false; | ||
| if (event instanceof JobStartedEvent) { | ||
| Job job = (Job) source; | ||
| if (job.getStatus() instanceof org.xwiki.job.AbstractJobStatus |
There was a problem hiding this comment.
I might have used an aspect for injecting this condition check, but it felt easier to do it like that.
| import org.xwiki.job.event.status.JobStatus; | ||
| import org.xwiki.job.event.status.QuestionAnsweredEvent; | ||
| import org.xwiki.job.internal.AbstractJobStatus; | ||
| import org.xwiki.job.AbstractJobStatus; |
There was a problem hiding this comment.
This impacts a condition in #onJobStarted which is called from #onEvent hence the legacy class I added to support the condition with the old class.
There was a problem hiding this comment.
Those should have moved to org.xwiki.job.AbstractJobStatus back when it was introduced. There is no need to introduce any legacy for this change, as org.xwiki.job.internal.AbstractJobStatus is a org.xwiki.job.AbstractJobStatus too.
| @Named(ExtensionJobHistoryRecorder.NAME) | ||
| @Singleton | ||
| @Deprecated | ||
| public class LegacyExtensionJobHistoryRecorder extends ExtensionJobHistoryRecorder |
There was a problem hiding this comment.
Seems to me this class is actually useless.
No description provided.