fix(did you mean): OMNI_SUBCOMMAND set to selected command#924
Merged
Conversation
At this time, the `OMNI_SUBCOMMAND` kept the original value used by the caller before selecting the real command from the `Did you mean?` menu; this led to issues for commands depending on `OMNI_SUBCOMMAND` to show the help, for instance. This is now fixed as it will set the `OMNI_SUBCOMMAND` environment variable to the selected command in the `Did you mean?` menu. Fixes #919
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At this time, the
OMNI_SUBCOMMANDkept the original value used by the caller before selecting the real command from theDid you mean?menu; this led to issues for commands depending onOMNI_SUBCOMMANDto show the help, for instance.This is now fixed as it will set the
OMNI_SUBCOMMANDenvironment variable to the selected command in theDid you mean?menu.Fixes #919