Drop BUILT_TIME_UTC #3081
Merged
Drop BUILT_TIME_UTC #3081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make builds reproducible. See https://reproducible-builds.org/ for why this is good.
Codecov ReportBase: 86.97% // Head: 86.91% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3081 +/- ##
==========================================
- Coverage 86.97% 86.91% -0.07%
==========================================
Files 83 83
Lines 33129 33128 -1
==========================================
- Hits 28813 28792 -21
- Misses 4316 4336 +20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lu-zero
approved these changes
Dec 12, 2022
Collaborator
lu-zero
left a comment
There was a problem hiding this comment.
It is fine by me, @shssoichiro are you ok with it?
Collaborator
|
Yeah, this seems fine 👍 |
This was referenced Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop
BUILT_TIME_UTCto make builds reproducible.
See https://reproducible-builds.org/ for why this is good.
Alternatively someone could patch
built/src/lib.rsto supportSOURCE_DATE_EPOCH