Skip to content

Conversation

@barrbrain
Copy link
Collaborator

@barrbrain barrbrain commented Nov 22, 2023

This reverts Cargo.toml and Cargo.lock to the state prior to #3241, except that the changes in #3283 are re-applied.
Updated all uniquely versioned packages. This did not cause the deploy workflow to regress.
Manually updated remaining packages and verified with deploy workflow.
The following packages are not udpated from v0.48.0:

  • windows-targets
  • windows_aarch64_gnullvm
  • windows_aarch64_msvc
  • windows_i686_gnu
  • windows_i686_msvc
  • windows_x86_64_gnu
  • windows_x86_64_gnullvm
  • windows_x86_64_msvc
    Finally, we may re-apply the Cargo.toml changes, taking care to pin the above packages,

@codecov
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b2f8ee) 88.22% compared to head (395254e) 88.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3290   +/-   ##
=======================================
  Coverage   88.22%   88.22%           
=======================================
  Files          86       86           
  Lines       28221    28221           
=======================================
  Hits        24898    24898           
  Misses       3323     3323           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@barrbrain barrbrain requested a review from lu-zero November 22, 2023 13:40
@barrbrain barrbrain force-pushed the fix-ci branch 2 times, most recently from 27b188d to 80c0a4d Compare November 22, 2023 15:33
@barrbrain barrbrain requested a review from tmatth November 22, 2023 15:42
Downgrade the following pacakges to 0.48.0:
- windows-targets
- windows_aarch64_gnullvm
- windows_aarch64_msvc
- windows_i686_gnu
- windows_i686_msvc
- windows_x86_64_gnu
- windows_x86_64_gnullvm
- windows_x86_64_msvc

This resolves a deploy workflow failure.
@barrbrain barrbrain merged commit 0681898 into xiph:master Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants