Don't use host's strip command when cross-compiling #3333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looks good. Could you please run |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3333 +/- ##
=======================================
Coverage 88.52% 88.52%
=======================================
Files 89 89
Lines 28334 28334
=======================================
Hits 25084 25084
Misses 3250 3250 ☔ View full report in Codecov by Sentry. |
Collaborator
|
I wonder if would be possible to tell nasm to not emit those symbols to begin with now. The patch seems fine. |
lu-zero
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS,
cargo build --target=x86_64-unknown-linux-muslmakes rustc panic in compiler/rustc_codegen_llvm/src/back/archive.rs:397:67, because thelibrav1easm.afile is invalid and unusable. This is because running aarch64-darwin'sstripcommand run on an x86-64-musl archive ruins it.I've made rav1e not run
stripduring cross-compilation, unlessCARGO_TARGET_{target}_STRIPorSTRIPenv var is set.