keymap: Rename long key/alias names in v1 format #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename keys and aliases with names longer than 4 characters when serializing using `XKB_KEYMAP_FORMAT_TEXT_V1`, to ensure compatibility with the X11 ecosystem. The new name is one of the following 2 forms: - If key name and keycode ≤ 0xfff: prefix character + hexadecimal keycode - If alias or keycode > 0xfff: prefix character + hexadecimal incrementing counter. Prefixes are chosen in the set “!#$%&'()*+,-./0” and avoid any name conflict. In the very unlikely case that renaming fails due to unavailable prefixes, the original name is kept so that Wayland clients can still parse the keymap.
67ff7e7 to
7db3d9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename keys and aliases with names longer than 4 characters when serializing using
XKB_KEYMAP_FORMAT_TEXT_V1, to ensure compatibility with the X11 ecosystem.See #849 for an example of such keymap in use.