include rulesMeta by default for all linting #674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
👍 Is this something you would be willing to do in this PR? |
Contributor
Author
Sure! The change is simple but a little more involved than in lintText, will need to update a few tests as well. Give me a couple of days for the changes and I will ping you again for re-review. |
Contributor
Author
|
Per the latest update to this PR:
|
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple addition for use in the vscode extension.
I had added a different package to get the rule docs, but it is broken for mono-repo based plugins, and this change was simpler than fixing the third party rule-docs package.
Note: we may want to add a similar change to lintFiles as we currently construct our urls in eslint-formatter-pretty with the broken package I mentioned.
related to: xojs/vscode-linter-xo#112