Make --stdin --fix always return the code even if nothing was fixed#383
Merged
sindresorhus merged 1 commit intoxojs:masterfrom Apr 29, 2019
Merged
Conversation
--stdin --fix always return the code even if nothing was fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An issue I ran into when writing an Emacs function for xo auto-fixing my buffer is when the stdin passed to xo has no code issues, the command
xo --stdin --fixwill returnundefined, which is a pain in the side. This small fix should hopefully alleviate that with minimal side effects.I couldn't find any documentation stating that was to be the desired behavior, and I did find this issue with the same problem from a couple years back: #245
Let me know if I'm PR-ing the wrong project, and I should be investigating ESLint instead!