Avoid crash when triggering automatic page addition by dragging selection #6868
+42
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I implemented a much better fix. It wasn't as complicated as I thought. So now:
|
rolandlo
approved these changes
Dec 17, 2025
Member
rolandlo
left a comment
There was a problem hiding this comment.
LGTM! I only have one minor comment about an include.
Collaborator
Author
|
Thanks for the review! |
Member
Yes, sure. I didn't notice that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6240
This fixes the crash, but does not really fix the underlying issue with the automatic page addition feature.The crash was caused by the following path. As the user drags the selection downwards, the
EditSelection::edgePanHandler()callback gets called. It triggers a scrolling (Layout::scrollRelative()). This scrolling in turn triggers a call toLayout::maybeAddPage(), with then adds a page.When adding a page, we always clear selections and text edition (see
PageBackgroundController::insertNewPage()), so the EditSelection instance which triggered all that gets destroyed... We then get the SegFault when the EditSelection instance gets accessed after deletion.Now, this PR fixes the crash, BUT the selected items still often disappear (they are in fact added to a page, but outside its bound and thus get deleted...).A proper fix would need to have the automatic page addition feature made aware of existing selections, and ensuring that the content stays selected. That would be some work - the code around this feature is a bit scattered and some refactoring would be required.
Edit: Stroke out the outdated description. See post below.