Release 2.2.5#1072
Merged
Merged
Conversation
See notice deprecation: https://www.npmjs.com/package/tslint
Incorporates various changes to package dependencies, Rollup and TS config in order to bump up the main TypeScript version to 5.4.4
Fixes `super` lookups that weren’t able to be resolved due to TypeScript not recognising the context in arrow functions declared as properties on the class or constructor. See: https://github.com/basarat/typescript-book/blob/master/docs/arrow-functions.md#tip-arrow-functions-and-inheritance
Might be a good idea to generalise this record type for reuse throughout this module rather than declaring everything repeatedly inline.
The global `jasmine` API has been removed from Jest with the new test runner `jest-circus` introduced in v27–v29. While possible to import the legacy Jasmine package, it seemed to be more robust to upgrade to the `jest.fn` API which behaves exactly the same as `jasmine.createSpy`. The main difference is the `callThrough()` method in Jasmine spies. This behaviour is the default for `jest.fn()`, so the upgrade works as-is.
This prevents the linter from blowing up with hundreds of notices about trailing commas in multi-line function arg lists that don’t match the style of the codebase.
smwhr
commented
Jul 31, 2024
smwhr
commented
Jul 31, 2024
smwhr
commented
Jul 31, 2024
| "main": "dist/ink-full.js", | ||
| "types": "ink.d.ts", | ||
| "files": ["src/engine","src/compiler","ink.d.ts", "ink.d.mts","script/inkjs-compiler.ts", "dist"], | ||
| "files": ["engine","compiler","ink.d.ts", "ink.d.mts","script/inkjs-compiler.ts", "dist"], |
Collaborator
Author
There was a problem hiding this comment.
Mistakenly exported the source files instead of the built files, sorry about that !
smwhr
commented
Jul 31, 2024
smwhr
commented
Jul 31, 2024
| "lint": "eslint 'src/**/*.ts'", | ||
| "lint:fix": "npm run lint -- --fix", | ||
| "watch": "tsc -p ./ && rollup -c -w", | ||
| "prepare": "npm run build" |
Collaborator
Author
There was a problem hiding this comment.
prepare was triggered all the time, I suggest we just be redondant in the run test steps.
smwhr
commented
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm test).npm run-script lint).Description
Tries to fix issues raised on github and Discord :
import { Story } from 'inkjs';in 2.2.3 / 2.2.4 #1065Fixes imports :
from 'inkjs' or require('inkjs'): Story and Inklist
from 'inkjs/full' or require('inkjs/full') : same as above + Compiler and co for javascript
from 'inkjs/types' : same as above but typed for typescript (pain to use in pure JS for reasons)
from 'inkjs/compiler/Deeply/Nested/Thing' : works again
Also :