Skip to content

delete unused ExceptionInsideResponseBody exception #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mitchellwrosen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

delete unused ExceptionInsideResponseBody exception #962

mitchellwrosen wants to merge 1 commit into from
+4 −20

Conversation

@mitchellwrosen
Copy link
Contributor

@mitchellwrosen mitchellwrosen commented Dec 21, 2023

This PR deletes the unused ExceptionInsideResponseBody exception.

@mitchellwrosen mitchellwrosen force-pushed the delete-exception-inside-response-body branch from 871e158 to bef63f5 Compare December 21, 2023 17:08
@kazu-yamamoto kazu-yamamoto self-requested a review December 22, 2023 00:48
@kazu-yamamoto
Copy link
Contributor

kazu-yamamoto commented Dec 22, 2023

ExceptionInsideResponseBody was introduced in #740
But the code throwing ExceptionInsideResponseBody was unintentionally removed.
We should recover this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kazu-yamamoto kazu-yamamoto Awaiting requested review from kazu-yamamoto

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mitchellwrosen @kazu-yamamoto