Unable to detect file changes on hamlet templates on stack devel for lts-12.5 #1551

Activity

1. snoyberg commented on Aug 10, 2018

   

   snoyberg

   on Aug 10, 2018

   Member

   More actions

   That's most likely a different in how GHC is reporting the watched files in the two different versions. There should be some .hi-dump files in your .stack-work directory. Can you report whether those files reference your Hamlet files with the two different resolvers?
2. jvliwanag commented on Aug 10, 2018

   

   jvliwanag

   on Aug 10, 2018

   Last edited by jvliwanag

   Author

   More actions

   Looks like they point to the same file, but have the 12.5 has an additional hex string.

   11.20 (working auto build)
   Path: ./.stack-work/dist/x86_64-osx/Cabal-2.0.1.0/build/src/Handler/Home.dump-hi

   addDependentFile "templates/homepage.hamlet"
   54086c982e9b4ed881fcb2d9d3c2aa4d
     $trModule :: GHC.Types.Module
     {- HasNoCafRefs, Strictness: m,
        Unfolding: (GHC.Types.Module
                      Handler.Home.$trModule3
                      Handler.Home.$trModule1) -}
   

   12.5 (auto build not working)
   Path: ./.stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/src/Handler/Home.dump-hi

   addDependentFile "templates/homepage.hamlet" 64b74188b62bac042119e8a0d26c3289
   3886f14f725c6b9c0e89769a9758c7a7
     $trModule :: GHC.Types.Module
     {- HasNoCafRefs, Strictness: m,
        Unfolding: (GHC.Types.Module
                      Handler.Home.$trModule3
                      Handler.Home.$trModule1) -}
   
3. snoyberg commented on Aug 10, 2018

   

   snoyberg

   on Aug 10, 2018

   Member

   More actions

   Good catch, looks like Stack needs to be updated to support that hex. I'm running out for the weekend right now, but a patch along these lines would probably do the trick. But I won't be able to try this out myself until next week:

   diff --git a/src/Stack/Package.hs b/src/Stack/Package.hs
   index ef986e95..d5ceb779 100644
   --- a/src/Stack/Package.hs
   +++ b/src/Stack/Package.hs
   @@ -1184,8 +1184,9 @@ parseDumpHI dumpHIPath = do
                -- It can be an absolute or relative path.
                mapMaybe
                    (fmap TL.unpack .
   -                  (TL.stripSuffix "\"" <=< TL.stripPrefix "\"") .
   -                  TL.dropWhileEnd (== '\r') . TLE.decodeUtf8 . CL8.dropWhile (/= '"')) $
   +                  TL.stripPrefix "\"" .
   +                  -- Starting with GHC 8.4.3, there's a hash following the path
   +                  TL.takeWhile (/= '\"') . TLE.decodeUtf8 . CL8.dropWhile (/= '"')) $
                filter ("addDependentFile \"" `CL8.isPrefixOf`) dumpHI
        thDepsResolved <- liftM catMaybes $ forM thDeps $ \x -> do
            mresolved <- liftIO (forgivingAbsence (resolveFile dir x)) >>= rejectMissingFile
4. snoyberg

   added 4 commits that reference this issue on Aug 13, 2018

   Handle hash at the end of addDependentFile

   ...

   This issue will close once commit 03dfaa8 is merged into the 'master' branch.

   03dfaa8

   Handle hash at the end of addDependentFile

   ...

   This issue will close once commit 7e36fb0 is merged into the 'master' branch.

   7e36fb0

   Handle hash at the end of addDependentFile

   ...

   This issue will close once commit 6069de4 is merged into the 'master' branch.

   6069de4

   Handle hash at the end of addDependentFile

   ...

   This issue will close once commit aae15e3 is merged into the 'master' branch.

   aae15e3
5. snoyberg

   closed this as completedin aae15e3on Aug 13, 2018
6. StevenXL

   added a commit that references this issue on Aug 31, 2018

   Use stack clean when building.

   ...

   bc2b0a6
7. ygale commented on Oct 24, 2018

   

   ygale

   on Oct 24, 2018

   More actions

   Even with versions of stack that include the linked fix, yesod devel still does not detect changes to hamlet files.

   In GHC 8.2 and earlier, referenced hamlet files appear as addDependentFile lines in the .dump-hi file. But in GHC 8.4 these lines do not appear. That appears to be the cause of the problem.
8. borsboom

   added a commit that references this issue on Oct 24, 2018

   Handle hash at the end of addDependentFile

   ...

   This issue will close once commit 72a1976 is merged into the 'master' branch.

   72a1976
9. ygale commented on Oct 25, 2018

   

   ygale

   on Oct 25, 2018

   More actions

   I am still experiencing this issue. Perhaps it should be re-opened?

   The underlying stack issue is commercialhaskell/stack#4360.
10. ygale commented on Oct 25, 2018

    

    ygale

    on Oct 25, 2018

    More actions

    The problem was that you also need shakespeare >= 2.0.19, which is only in the latest LTS 12.14. Thanks to @tolysz for pointing that out. You need stack >= 1.9.3 (not yet released) to get @snoyberg's fix, or in the meantime you can build >= 1.9.2 from the stable branch on github.

    I am now convinced that this issue is fixed. Thanks!

    👍React with 👍1Reacted by Артур Файзрахманов

    ❤️React with ❤️1Reacted by Артур Файзрахманов
11. spacekitteh commented on Jan 31, 2019

    

    spacekitteh

    on Jan 31, 2019

    More actions

    I'm not. I just updated to 1.9.3, and addDependentFile generates the following error from within GHC:

    *** Core Linted result of Desugar (after optimization): *** Deleting temp files: Deleting: C:\Users\SPACEK~1\AppData\Local\Temp\ghc3940_0\ghc_1.hscpp C:\Users\SPACEK~1\AppData\Local\Temp\ghc3940_0\ghc_3.hscpp C:\Users\SPACEK~1\AppData\Local\Temp\ghc3940_0\ghc_5.hscpp *** Deleting temp dirs: Deleting: C:\Users\SPACEK~1\AppData\Local\Temp\ghc3940_0 C:\Users\spacekitteh: openBinaryFile: permission denied (Permission denied)
12. ygale commented on Feb 2, 2019

    

    ygale

    on Feb 2, 2019

    More actions

    @spacekitteh Could you please post more details? So far I don't see the connection with addDependentFile. Thanks!
13. spacekitteh commented on Feb 2, 2019

    

    spacekitteh

    on Feb 2, 2019

    More actions

    @ygale I just realised I posted this in the yesod tracker, rather than stack. But, when I comment out the addDependentFile line in my TH code, it works; when I leave it in, it gets permission errors.