docs: Update instructions for dev server and testing push notifications #5921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This name got cleaned up, hooray. (A couple of years ago -- zulip/zulip@43b4f1057 -- but we use these instructions only occasionally and update them less often than that.)
In particular PUSH_NOTIFICATION_BOUNCER_URL was replaced by ZULIP_SERVICES_URL last year, in zulip/zulip@4a9314943. I believe the need for a distinct EXTERNAL_HOST value when registering the server with the bouncer came about as part of the same work around the same time, though it may have been in a different commit. Also at some point the spelling of the flag got fixed to use hyphens as in the normal CLI convention. Chat thread, where I found the existing instructions no longer worked and then we debugged: https://chat.zulip.org/#narrow/channel/243-mobile-team/topic/notifications.20from.20dev.20server/near/2159857 With these changes, the instructions work for me. (I didn't wipe my dev server to verify it works from there, but I did reset all the state I believe is relevant: removed my old custom_dev_settings.py and the two `zulip_org_*` items from dev-secrets.conf .)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chat thread: #mobile-team > notifications from dev server @ 💬
This is a companion change to:
Commit messages
e632d77 docs: Update dev-server instructions for tools/run-dev rename
This name got cleaned up, hooray. (A couple of years ago --
zulip/zulip@43b4f1057 -- but we use these instructions only
occasionally and update them less often than that.)
3fa6250 docs/push-notifications: Update how to register with bouncer
In particular PUSH_NOTIFICATION_BOUNCER_URL was replaced by
ZULIP_SERVICES_URL last year, in zulip/zulip@4a9314943.
I believe the need for a distinct EXTERNAL_HOST value when
registering the server with the bouncer came about as part of the
same work around the same time, though it may have been in a
different commit.
Also at some point the spelling of the flag got fixed to use
hyphens as in the normal CLI convention.
Chat thread, where I found the existing instructions no longer
worked and then we debugged:
https://chat.zulip.org/#narrow/channel/243-mobile-team/topic/notifications.20from.20dev.20server/near/2159857
With these changes, the instructions work for me. (I didn't wipe my
dev server to verify it works from there, but I did reset all the
state I believe is relevant: removed my old custom_dev_settings.py
and the two
zulip_org_*items from dev-secrets.conf .)91f5c32 docs/push-notifications: Add troubleshooting for missing "plan"