feat!: remove deprecated features for 2.0.0#25
Merged
Conversation
Remove every deprecated and already-removed feature ahead of the 2.0.0
release, along with the supporting deprecation infrastructure:
- opts.confirm -> defaults.confirm
- opts.disable_vim_loader -> performance.vim_loader
- opts.plugins_dir -> { import = 'dir' } in spec
- opts.cmd_prefix and the legacy :Z* commands -> :ZPack <subcommand>
- opts.auto_import (already a no-op; notice dropped)
- zpack.add() (already a no-op; function dropped)
With nothing left to notify, zpack.deprecation is now unused and is
deleted, state.deprecations is removed, and :checkhealth zpack no
longer reports deprecated options.
BREAKING CHANGE: the options and commands listed above no longer work.
Migrate to the replacements shown before upgrading to 2.0.0.
3b8b069 to
30de216
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes every deprecated and already-removed feature ahead of the 2.0.0 release, along with the supporting deprecation infrastructure.
opts.confirmdefaults.confirmopts.disable_vim_loaderperformance.vim_loaderopts.plugins_dir{ import = 'dir' }in specopts.cmd_prefix+ legacy:Z*commands:ZPack <subcommand>opts.auto_importzpack.add()With nothing left to notify,
zpack.deprecationis now unused and is deleted,state.deprecationsis removed, and:checkhealth zpackno longer reports deprecated options.Changes
init.lua— drop deprecatedopts.*handling, thecmd_prefix/legacy_prefixplumbing, thestate.deprecationsrecording loop, theM.addstub, and the@deprecatedfields onzpack.Config.commands.lua— delete the legacy commands section (LEGACY_SUFFIXES,M.setup_legacy).health.lua— drop the deprecation-reporting block fromcheck_config.validate.lua— drop the legacy-option type checks; update doc comment.state.lua— remove thedeprecationsfield.deprecation.lua— deleted (fully unused).deprecation_test.luaandcmd_prefix_test.lua; trim deprecation-specific cases fromsetup_test.lua,health_test.lua,validate_test.lua; simplifyhelpers.delete_zpack_commands.:checkhealthdescription inREADME.mdanddoc/zpack.txt.The options and commands listed above no longer work. Users must migrate to the replacements shown before upgrading to 2.0.0.
Test plan
nvim -u NONE -l tests/busted.lua— 364 passed / 0 failedluacheck lua/ tests/— 0 warnings / 0 errorslua-language-server --check— no new diagnostics (pre-existing count unchanged)Closes zpack_nvim-prf.