Performance improvements for pan & zoom#302
Merged
Merged
Conversation
1a5cd46 to
7e317ab
Compare
7e317ab to
e23d1c4
Compare
e23d1c4 to
1f2c40e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes fix a performance issue with tooltips on objects. When many objects have mouseover event listeners, then pan/zoom performance suffers. Therefore, the tooltip behaviors were optimized so this performance hit only occurs when the tooltips are activated over objects, which is not the default setting.
This PR also implements requestAnimationFrame for more predictable performance with pan/zoom.
Also disabled the grabbing cursor which was causing slowdowns