fix(variables): file variable substitution alignment#4866
Merged
Conversation
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
✅ Deploy Preview for zarf-docs canceled.
|
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
brandtkeller
commented
May 1, 2026
| - name: Run golangci-lint | ||
| uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0 | ||
| with: | ||
| version: v2.12.0 No newline at end of file |
Member
Author
There was a problem hiding this comment.
I had an inconsistency between local version and CI - added versioning pin here given current work to standardize.
AustinAbro321
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The bug highlights an issue regarding the lifecycle of variable replacement. Inspect performs replacement instead of relying upon the helm wrapper postrender logic. There was a change in upstream postrender/kyaml workflows that strippedi indentation based on an empty field as a result of the content of the original resource only have "comments".
This would propose templating files before the helm wrapper logic and reverses the order of operations such that variable replacement happens before go templating - the order used consistently for templating operations.
Need to consider any edge cases or permutations of components that may be impacted by this change in sequence.
Related Issue
Fixes #4863
Checklist before merging