Skip to content

chore(deps): limit dependencies in favor of built-ins or core libs#4901

Merged
soltysh merged 2 commits into
zarf-dev:mainfrom
soltysh:deps_replacement_1
May 18, 2026
Merged

chore(deps): limit dependencies in favor of built-ins or core libs#4901
soltysh merged 2 commits into
zarf-dev:mainfrom
soltysh:deps_replacement_1

Conversation

@soltysh

@soltysh soltysh commented May 14, 2026

Copy link
Copy Markdown
Contributor

Description

This PR introduces two changes:

  1. Replace controller-runtime helpers with k8s native client-go ones. Allowing us to drop direct dependency, although not entirely eliminating it due to transitive dependency through flux.
  2. Replace custom helpers (helpers.RemoveMatches) with golang buitl-in slices counterparts.

Related Issue

Relates to #4895

Checklist before merging

@soltysh soltysh requested review from a team as code owners May 14, 2026 14:35
@netlify

netlify Bot commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 41497d5
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/6a0b4cdd03ed0b00084617b4

@codecov

codecov Bot commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/cluster/cluster.go 0.00% 2 Missing ⚠️
src/pkg/packager/remove.go 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/packager/pull.go 50.00% <100.00%> (ø)
src/pkg/cluster/cluster.go 49.77% <0.00%> (+0.33%) ⬆️
src/pkg/packager/remove.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

AustinAbro321
AustinAbro321 previously approved these changes May 15, 2026
View reviewed changes

@AustinAbro321 AustinAbro321 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just need to fix conflicts

soltysh added 2 commits May 18, 2026 19:30
@soltysh
chore(deps): use native k8s.io/client-go instead of controller-runtim…
b16df46 
…e for mapper

Signed-off-by: Maciej Szulik <maciej@defenseunicorns.com>
@soltysh
chore(deps): use golang native slices rather than helper functions
41497d5 
Signed-off-by: Maciej Szulik <maciej@defenseunicorns.com>
@soltysh soltysh force-pushed the deps_replacement_1 branch from 4ca3ca7 to 41497d5 Compare May 18, 2026 17:31
@soltysh

soltysh commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@AustinAbro321 mind re-reviewing after the conflicts has been resolved.

@soltysh soltysh enabled auto-merge May 18, 2026 17:33
@soltysh soltysh added this pull request to the merge queue May 18, 2026
Merged via the queue into zarf-dev:main with commit ba7ba4f May 18, 2026
32 checks passed
@soltysh soltysh deleted the deps_replacement_1 branch May 18, 2026 18:31
@github-project-automation github-project-automation Bot moved this to Done in Zarf May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtkeller brandtkeller brandtkeller approved these changes

@AustinAbro321 AustinAbro321 AustinAbro321 left review comments

Assignees

No one assigned

Labels

None yet

Projects

Zarf
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@soltysh @AustinAbro321 @brandtkeller