Skip to content

FeaturePanel: Add coloring for opening times to indicate state #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
homtec wants to merge 5 commits into
base: master
Choose a base branch
from
Open

FeaturePanel: Add coloring for opening times to indicate state #1141

homtec wants to merge 5 commits into from

Conversation

@homtec
Copy link

@homtec homtec commented Jul 5, 2025 •
edited
Loading

Description

See at one glance if the POI is open or closed by setting appropriate colors.

Example links

Screenshots

image

Checklist

  • dark mode / light mode
  • mobile / desktop
  • server-side-rendering (SSR)
  • all texts are localized (in vocabulary.ts)

@vercel
Copy link

vercel bot commented Jul 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
osmapp Ready Ready Preview Oct 22, 2025 1:01pm

@homtec homtec changed the title add coloring for opening times to indicate state FeaturePanel: Add coloring for opening times to indicate state Jul 5, 2025
@Dlurak
Copy link
Collaborator

Dlurak commented Jul 9, 2025

Good idea and thanks for making the effort to implement it 👍

But I think the colour is a bit too prominent/pushy, maybe only show the word coloured and not the time, so for example only the "Closed now" or "Opens soon"...
What do you think?

@homtec
Copy link
Author

homtec commented Jul 10, 2025

Agree, will change it. 👍

@homtec
Copy link
Author

homtec commented Oct 20, 2025

Ready to rumble

@homtec
Copy link
Author

homtec commented Oct 22, 2025

Good idea and thanks for making the effort to implement it 👍

But I think the colour is a bit too prominent/pushy, maybe only show the word coloured and not the time, so for example only the "Closed now" or "Opens soon"... What do you think?

Okay, I’ve updated it as requested, @Dlurak!

@zbycz
Copy link
Owner

zbycz commented Nov 4, 2025

Hi, i clicked around the app. And this usecase doesn't look good to me. I guess that only the "Closed now" part should be colored in this case. (The amenity is closed, but it will be opened later that day)

image

I am not sure it is worth updating the code and all the translations properly, but I leave the decision up to you.
Currently i would not merge it, because it looks more strange than before 😇

@zbycz zbycz force-pushed the master branch 3 times, most recently from 94a02da to d1089f3 Compare December 14, 2025 12:13
@zbycz zbycz force-pushed the master branch 3 times, most recently from 87b5169 to 2675c4f Compare December 19, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@homtec @Dlurak @zbycz