Skip to content

Conversation

@XOR-op
Copy link

@XOR-op XOR-op commented Apr 1, 2025

Fixes #3416 #3337 .

This PR focuses on improving user experience: when users detach all clients, the next time users attach to the session, they expect to see the last tab they were at from the last connection, instead of always being the first tab. The changes in this PR allow a session to remember the last tab position on exit globally, and restore to it. When there is more than zero active client, no behavior will be changed.

The pane behavior described in related issues seems to have already been fixed.

@XOR-op XOR-op changed the title feat(zellij-server): restore tab position when re-attaching fix(zellij-server): restore tab position when re-attaching Apr 3, 2025
@XOR-op
Copy link
Author

XOR-op commented Nov 14, 2025

Hi @imsnif,

I understand review of PRs will be delayed, but this PR has been waiting 7 months without feedback and currently in the second page of PR list, lacking visibility. It's a 5-line fix for an issue affecting many users. It should not create additional burdens for you; however, this is important for enhancing the user experience for many users (see related issues).

Would appreciate any feedback when you have a moment.

@imsnif
Copy link
Member

imsnif commented Nov 15, 2025

Hi @XOR-op - thanks for the reminder. I can understand the frustration of having this going without feedback for a long while. This is not how I would like things to be handled.

Having said that, there are quite a few similar seemingly minor enhancements/fixes in a similar state. Many of them are similarly beneficial to user experience and seem similarly innocuous. All of them, including this one, are not trivial five-minute fixes/reviews for various reasons (an example in this case is that the aforementioned client_ids used as keys don't always refer to actual users and might cause havoc when combined with certain plugins/cli commands in certain situations).

I am aware of this issue and this fix - I promise I have not forgotten about it, and I promise to get to it. I cannot however promise an ETA. I'm doing my best maintaining, developing and directing this project and appreciate both your patience and trust in my prioritization of maintainer attention.

@XOR-op
Copy link
Author

XOR-op commented Nov 15, 2025

@imsnif Thanks for all the efforts you put for this project! I will wait until our maintainers have enough time. One request I have is could you approve CI workflow for this PR? Given non ETA is promised, I may need to catch up with the upstream. Allowing me to fix issues introduced by updates can reduce the burdens of reviewers when they have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zellij attach doesn't remember last opened pane/tab

2 participants