provide more semantic token information + refactor and fixes#1103
Merged
Conversation
Member
|
Few things that don't seem quite right. These four should all have the same color (also happened to notice that #445 doesn't work any more) Its weird that both usages of Edit: Okay, with the first one it seems like the color is due to whether zls is able to resolve the reference or not ( |
0df3c1b to
1f401ec
Compare
Member
Author
|
I've reverted the change about marking const declarations readonly and it now looks more consistent even though a bit less colorful. |
leecannon
approved these changes
May 20, 2023
93eaa6f to
5cc7b13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these changes had a visible effect depending on the theme used:
TokenTypeinstead ofTokenModifiersfixes #843
Here is how the above changed have affected highlighting.