Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses a panic occurring on non-Unicode lines by improving the display width calculation for output formatting. The changes include reordering imported items in src/shell.rs and src/main.rs, updating the spacing calculation in the hydration error output, and bumping various dependency versions and package metadata.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/shell.rs | Reordered imports for anyhow and sysinfo to match a new convention. |
| src/main.rs | Modified the spacing calculation in error output and reordering imports. |
| sdk/Cargo.toml | Updated package version from beta to stable release. |
| Cargo.toml | Bumped package version, edition, and various dependency versions. |
Comments suppressed due to low confidence (1)
src/shell.rs:1
- [nitpick] Ensure the import order is consistent with the project conventions; if alphabetical ordering is preferred, consider reordering to 'bail, Result'.
use anyhow::{Result, bail};
| eprintln!( | ||
| "| > {} {}|", | ||
| line, | ||
| " ".repeat(wrap_width - 2 - textwrap::core::display_width(&line)), |
There was a problem hiding this comment.
Ensure the computed space count never becomes negative; consider using a safety check (e.g., max(0, wrap_width - 2 - textwrap::core::display_width(&line))) to prevent any potential panic when handling unexpected display widths.
Suggested change
| " ".repeat(wrap_width - 2 - textwrap::core::display_width(&line)), | |
| " ".repeat(std::cmp::max(0, wrap_width - 2 - textwrap::core::display_width(&line))), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.