fix(handler): remove the two extra is_terminal sys call from MietteHandlerOpts::build#325
Merged
Merged
Conversation
…eHandlerOpts::build` `GraphicalReportHandler::new()` calls `GraphicalTheme::default()` https://github.com/zkat/miette/blob/7ff4f874d693a665af4df40f4e94505013e3e262/src/handlers/graphical.rs#L52 which calls `std::io::stdout().is_terminal()` and `std::io::stderr().is_terminal()` https://github.com/zkat/miette/blob/7ff4f874d693a665af4df40f4e94505013e3e262/src/handlers/theme.rs#L72 but this default theme is overridden by `with_theme(theme)`.
zkat
approved these changes
Feb 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphicalReportHandler::new()callsGraphicalTheme::default()miette/src/handlers/graphical.rs
Line 52 in 7ff4f87
which calls
std::io::stdout().is_terminal()andstd::io::stderr().is_terminal()miette/src/handlers/theme.rs
Line 72 in 7ff4f87
but this default theme is overridden by
with_theme(theme).