Skip to content

issues/vulnerabilities from security scan #601

Closed

Description

@DanielPutsch

Dear Developer,

I had to run an automated security scan of your code. The result is listed below. Can you please check the issues?

Thanks a lot!

Off By One Error:

Location: mz_zip_rw.c
Line: 1146
Source: strncpy(directory, path, sizeof(directory));
RelevantPart: sizeof
(See #611)

Improper Null Terminations:

Location: mz_strm_os_posix.c
Line: 107
Source: int32_t read = (int32_t)fread(buf, 1, (size_t)size, posix - >handle);
RelevantPart: buf

Location: mz_strm_wzaes.c
Line: 124
Source: memcpy(verify, kbuf + (2 * key_length), MZ_AES_PW_VERIFY_SIZE);
RelevantPart: verify

Location: mz_strm_mem.c
Line: 66
Source: memcpy(new_buf, mem - >buffer, mem - >size);
RelevantPart: new_buf

Location: mz_os_posix.c
Line: 174
Source: strncpy(name, path, len + 1);
RelevantPart: name
(See fe36527)

Location: mz_strm.c
Line: 285
Source: memmove(buf, buf + read, find_size);
RelevantPart: buf

Location: mz_zip_rw.c
Line: 1146
Source: strncpy(directory, path, sizeof(directory));
RelevantPart: directory
(See #611)

Activity

  1. nmoinvaz commented on Dec 18, 2021

    @nmoinvaz
    Member

    I accept pull requests. Thank you.

  2. nmoinvaz commented on Mar 5, 2022

    @nmoinvaz
    Member

    Only string ones have been fixed. If you require any other fixes, do pull request. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions