Fix package config install target#367
Merged
nmoinvaz merged 2 commits intoFeb 19, 2019
Merged
Conversation
Member
|
I was wondering about that EXISTS statement because I saw zlib didn't have one. But I didn't think it hurt anything. Thanks again for the fixes! |
Member
|
Actually i think it should be: |
Contributor
Author
|
I wouldn’t do that - why wouldn’t the file be there? It’s part of your repository as all the other sources are, right? So it’s a „fact“ and nothing „variable/condionally generated“ Also the current source dir reference is not needed since the relative path is easier to read and maintain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nmoinvaz sorry, but I screwed up the last fix - it actually did not fix the underlying issue
I removed the complete
if...endstatement since this is not necessary, CMake will take care of the generation.To make it up to you, I also removed the unnecessary trailing spaces :)
Please consider upgrading your travis CI to also do the installation step in order to figure these kinds of problems out in the first place.