mz_os_win32.c: kernel32.dll is always loaded, so use GetModuleHandleW().#448
Merged
Merged
Conversation
The kernel32.dll pathname code had two issues: 1. Using sizeof() for wchar_t[]. sizeof() returns the number of bytes, but the wcs*() functions need number of characters, so we end up telling wcsncat() that the buffer is twice as big as it actually is. 2. wcsncat()'s size parameter is supposed to be the *remaining* size in the buffer, not the total size. wcscat_s() should be used instead, since it takes the total size of the buffer. None of this is actually needed, since kernel32.dll is used by all Windows programs, so it's always loaded in memory.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kernel32.dll pathname code had two issues:
Using sizeof() for wchar_t[]. sizeof() returns the number of bytes, but the wcs*() functions need number of characters, so we end up telling wcsncat() that the buffer is twice as big as it actually is.
wcsncat()'s size parameter is supposed to be the remaining size in the buffer, not the total size. wcscat_s() should be used instead, since it takes the total size of the buffer.
None of this is actually needed, since kernel32.dll is used by all Windows programs, so it's always loaded in memory.