Skip to content

Use __has_include instead of preprocessor defines.#484

Merged
nmoinvaz merged 2 commits into
zlib-ng:devfrom
triplef:use-has-include
Jun 7, 2020
Merged

Use __has_include instead of preprocessor defines.#484
nmoinvaz merged 2 commits into
zlib-ng:devfrom
triplef:use-has-include

Conversation

@triplef

@triplef triplef commented May 29, 2020

Copy link
Copy Markdown
Contributor

As discussed this lets the compiler check for header availability.

I left the checks for HAVE_STDINT_H and HAVE_INTTYPES_H in CMakeLists, as they still seem to be used in liblzma.

@nmoinvaz

nmoinvaz commented Jun 6, 2020

Copy link
Copy Markdown
Member

@triplef can you confirm my change works for you still?

@nmoinvaz nmoinvaz changed the base branch from master to dev June 7, 2020 01:37
@nmoinvaz nmoinvaz merged commit b6bbb9f into zlib-ng:dev Jun 7, 2020
@nmoinvaz

nmoinvaz commented Jun 7, 2020

Copy link
Copy Markdown
Member

Merged into dev branch. Thanks!

@triplef triplef deleted the use-has-include branch June 7, 2020 09:02
@triplef

triplef commented Jun 7, 2020

Copy link
Copy Markdown
Contributor Author

Thank you. This works great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants