Fix SOVERSION in Linux#592
Merged
Merged
Conversation
Member
|
I'm okay if it just says "3" with no if statement. |
Contributor
Author
|
update, without platform differentiation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Linux (and BSD) the
SOVERSIONonly consists of the major version number. The correct symbolic links have to beand the SONAME of libminizip.so.3.0.2 is
libminizip.so.3. By this change the symbolic links are created correctly.On other platforms, such as Windows and macOS, the
SOVERSIONmay well consist of<major-minor>. That's why I added the if-else statement.See also: https://cmake.org/cmake/help/latest/prop_tgt/SOVERSION.html