Skip to content

Fixed disk spanning failures in CI #808

Merged
nmoinvaz merged 1 commit into
developfrom
fix-ci
Oct 30, 2024
Merged

Fixed disk spanning failures in CI #808
nmoinvaz merged 1 commit into
developfrom
fix-ci

Conversation

@nmoinvaz

@nmoinvaz nmoinvaz commented Oct 30, 2024

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Oct 30, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.01%. Comparing base (b2691a0) to head (14eadcc).
Report is 1 commits behind head on develop.

❗ Current head 14eadcc differs from pull request most recent head 18ddbf9

Please upload reports for the commit 18ddbf9 to get more accurate results.

Files with missing lines Patch % Lines
mz_strm_split.c 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #808      +/-   ##
===========================================
- Coverage    62.29%   62.01%   -0.29%     
===========================================
  Files           32       32              
  Lines         9734     9735       +1     
  Branches      2386     2387       +1     
===========================================
- Hits          6064     6037      -27     
- Misses        2379     2392      +13     
- Partials      1291     1306      +15
Flag Coverage Δ
macos_xcode 55.48% <0.00%> (-0.01%) ⬇️
macos_xcode_libcompression 55.48% <0.00%> (-0.01%) ⬇️
macos_xcode_openssl 55.48% <0.00%> (-0.01%) ⬇️
ubuntu_clang 60.84% <33.33%> (-0.31%) ⬇️
ubuntu_clang_compress_only 46.87% <0.00%> (-0.01%) ⬇️
ubuntu_clang_decompress_only 32.94% <0.00%> (-0.01%) ⬇️
ubuntu_clang_no_bzip2 60.84% <33.33%> (-0.31%) ⬇️
ubuntu_clang_no_encryption 55.65% <33.33%> (-0.35%) ⬇️
ubuntu_clang_no_lzma 60.25% <33.33%> (-0.32%) ⬇️
ubuntu_clang_no_pkcrypt 60.47% <33.33%> (-0.32%) ⬇️
ubuntu_clang_no_winzip_aes 60.35% <33.33%> (-0.32%) ⬇️
ubuntu_clang_no_zlib 54.10% <33.33%> (-0.30%) ⬇️
ubuntu_clang_no_zstd 60.46% <33.33%> (-0.32%) ⬇️
ubuntu_clang_openssl 60.84% <33.33%> (-0.31%) ⬇️
ubuntu_gcc 60.44% <33.33%> (-0.34%) ⬇️
windows_gcc 56.83% <33.33%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nmoinvaz
Fixed disk spanning failures due to changes in #799.
18ddbf9 
At the end of a disk, we return any bytes read before proceeding to
the next disk. This allows us to return MZ_EXIST_ERROR when the next
disk is not found.
@nmoinvaz nmoinvaz changed the title test Fixed disk spanning failures in CI Oct 30, 2024
@nmoinvaz nmoinvaz added disk splitting Disk spanning bug Bug labels Oct 30, 2024
@nmoinvaz nmoinvaz marked this pull request as ready for review October 30, 2024 17:01
@nmoinvaz nmoinvaz merged commit 6946ba6 into develop Oct 30, 2024
@nmoinvaz nmoinvaz deleted the fix-ci branch October 30, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Bug disk splitting Disk spanning

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nmoinvaz