Skip to content

update to use ppmd from 7zip 26.01#992

Open
pmqs wants to merge 1 commit into
zlib-ng:developfrom
pmqs:7zip-26.01
Open

update to use ppmd from 7zip 26.01#992
pmqs wants to merge 1 commit into
zlib-ng:developfrom
pmqs:7zip-26.01

Conversation

@pmqs
Copy link
Copy Markdown
Contributor

@pmqs pmqs commented May 1, 2026

refresh with latest 7zip upstream source

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 1, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 993b303d-c02b-405f-b1ce-853d1f254dc3

📥 Commits

Reviewing files that changed from the base of the PR and between cf938e8 and 5f9be99.

📒 Files selected for processing (2)
  • .github/workflows/ppmd-dependabot.yml
  • CMakeLists.txt
✅ Files skipped from review due to trivial changes (2)
  • .github/workflows/ppmd-dependabot.yml
  • CMakeLists.txt

Walkthrough

PPMd dependency version updated from 26.00 to 26.01 in both the GitHub Actions workflow and the CMake build configuration; inline comments added to document and enforce version alignment between the two files.

Changes

Cohort / File(s) Summary
PPMd Version Bump
.github/workflows/ppmd-dependabot.yml, CMakeLists.txt		 Updated expected PPMd version from 26.00 to 26.01 in both files; added inline comments indicating the version should match across the workflow and CMake configuration.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'update to use ppmd from 7zip 26.01' clearly and specifically describes the main change: upgrading PPMd to version 26.01 from 7zip.
Description check ✅ Passed The description 'refresh with latest 7zip upstream source' is related to the changeset, describing the general intent of updating dependencies to a newer upstream version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot reviewed May 1, 2026
View reviewed changes
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 553b1815-7076-43db-8df7-0f22ae49c8b8

📥 Commits

Reviewing files that changed from the base of the PR and between 947848c and cf938e8.

📒 Files selected for processing (2)
  • .github/workflows/ppmd-dependabot.yml
  • CMakeLists.txt

Comment thread .github/workflows/ppmd-dependabot.yml Outdated
Comment thread CMakeLists.txt Outdated
@nmoinvaz
Copy link
Copy Markdown
Member

nmoinvaz commented May 1, 2026

Does the dependabot script open PRs with the new versions?

@pmqs
Copy link
Copy Markdown
Contributor Author

pmqs commented May 1, 2026

Does the dependabot script open PRs with the new versions?

Afraid not. That would need cmake support from dependabot and it isn't there at the moment.

There is an open ticket to get cmake support added , but that is now a few years old. See dependabot/dependabot-core#7451

All this quick-and-dirty dependabot does is fail if it finds the hard-wired version is different upstream.

I only spotted this because I got a failure email from my fork of this repo.

Think we decided to keep with explicit versions of the 7zip source because there was a breaking API change at one point with the PPMd source.

The alternative is to clone the latest code from upstream and deal with any failures as they happen.

@nmoinvaz
Copy link
Copy Markdown
Member

nmoinvaz commented May 1, 2026

I think it might not be that hard to have the current workflow create a PR. I can take a look at it later I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pmqs @nmoinvaz