Skip to content

Tags: zmanda/amanda

Tags

tag-community-3.5.4

Toggle tag-community-3.5.4's commit message
fix CVE-2023-30577

tag-community-3.5.2

Toggle tag-community-3.5.2's commit message
2017-2019 general upkeep and one feature branch from 3.6 candidate

tag-3.6.0.pre3

Toggle tag-3.6.0.pre3's commit message
remove obsolete testing util

tag-3.6.0.pre2

Toggle tag-3.6.0.pre2's commit message
must silence these makes or they taint the list of tests

tag-3.6.0.pre1

Toggle tag-3.6.0.pre1's commit message
correct bad use of tag-names

tag-community-3.5.2rc4

Toggle tag-community-3.5.2rc4's commit message
Merge branch '3_5.modify-rpm-spec' into integ-3_5.rc4

tag-core-3.6.1

Toggle tag-core-3.6.1's commit message
make gpg2 silent or else pipeline is cancelled

tag-core-3.6.rel

Toggle tag-core-3.6.rel's commit message
client-src/rundump.c - Review comments fixes

Fixes done for security issues review comments. 
Comments provided by Dustin. J. Mitchell-
1. It would probably be better to use the preprocessor conditionals (`#if defined(DUMP)`, etc.) here instead of trying to figure out which program is in use at runtime. If an Amanda install is set up with, say, XFSDUMP=/opt/fs/old-xfsdump, then the code above would never call `validate_xfsdump_options`, even though it's clear that it's driving xfsdump.
2. Why not have the `validate_..` functions call `error(..)` themselves, rather than printing something (which might get lost) and then giving a blank error message (or more oddly, a single space character??) here? Alternately, `validate_..` could return an allocated error message.

Fixed issue:
1. Using getopt() to check the command option failed to check the blacklist option if the command is provided like:
/usr/lib/amanda/rundump NOCONFIG xfsdump -0f /dev/null /sys -F "echo test"
It was working fine when the command is provided like:
/usr/lib/amanda/rundump NOCONFIG xfsdump -0f /dev/null -F "echo test" /sys

git-svn-id: svn+ssh://svn.code.sf.net/p/amanda/code/amanda/branches/3_5@7716 a8d146d6-cc15-0410-8900-af154a0219e0

tag-community-3.5.1

Toggle tag-community-3.5.1's commit message
* application-src/ampgsql.pl: Accept --target asa synonyme for

  --directory


git-svn-id: https://svn.code.sf.net/p/amanda/code/amanda/branches/3_5@7556 a8d146d6-cc15-0410-8900-af154a0219e0