Skip to content

Sector Nord AG: Fixed Enter/Ctrl+Enter leads to saving the draft instead of submitting the form. #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dennykorsukewitz merged 1 commit into from
Sep 1, 2025
Merged

Sector Nord AG: Fixed Enter/Ctrl+Enter leads to saving the draft instead of submitting the form. #704

dennykorsukewitz merged 1 commit into from
Sep 1, 2025

Conversation

@LuBroering
Copy link
Contributor

@LuBroering LuBroering commented Aug 19, 2025 •
edited
Loading

Proposed change

In all browsers except Internet Explorer, the default type of the button was 'submit', causing Enter or Ctrl + Enter to trigger Save/Update Draft instead of submitting the form.
This change explicitly sets the button type to 'button', ensuring the intended behavior across all browsers.

Type of change

  • '1 - 🐞 bug 🐞'

Additional information

Issue: #635
PR: #554 & #498

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

@rkaldung rkaldung added 3 - verified This issue or pull request was verified. 3 - internal Issue/MR A Znuny internal issue/MR has been created. labels Aug 26, 2025
@dennykorsukewitz dennykorsukewitz changed the title Sector Nord AG: Fix Enter/Ctrl+Enter triggering draft save instead of form submission Sector Nord AG: Fixed: Enter/Ctrl+Enter leads to saving the draft instead of submitting the form. Aug 27, 2025
@dennykorsukewitz dennykorsukewitz self-requested a review August 27, 2025 21:11
@dennykorsukewitz dennykorsukewitz self-assigned this Aug 27, 2025
@dennykorsukewitz dennykorsukewitz added this to the rel-7_2_2 milestone Aug 27, 2025
@dennykorsukewitz
Copy link
Member

dennykorsukewitz commented Aug 27, 2025

Internal issue: 1238

dennykorsukewitz
dennykorsukewitz requested changes Aug 27, 2025
View reviewed changes
Copy link
Member

@dennykorsukewitz dennykorsukewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LuBroering ,
thanks for your PR.

Approved 👍

Regards 🚀

@dennykorsukewitz dennykorsukewitz added 2 - wait for contributor Contributor, it's your turn. 2 - wait for merge Znuny, it's your turn. and removed 2 - wait for contributor Contributor, it's your turn. labels Aug 27, 2025
@dennykorsukewitz dennykorsukewitz changed the title Sector Nord AG: Fixed: Enter/Ctrl+Enter leads to saving the draft instead of submitting the form. Sector Nord AG: Fixed Enter/Ctrl+Enter leads to saving the draft instead of submitting the form. Sep 1, 2025
@dennykorsukewitz dennykorsukewitz merged commit 2dd1448 into znuny:dev Sep 1, 2025
11 of 14 checks passed
@dennykorsukewitz dennykorsukewitz removed the 2 - wait for merge Znuny, it's your turn. label Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennykorsukewitz dennykorsukewitz dennykorsukewitz approved these changes

Assignees

@dennykorsukewitz dennykorsukewitz

Labels

3 - internal Issue/MR A Znuny internal issue/MR has been created. 3 - verified This issue or pull request was verified.

Milestone

rel-7_2_2

Development

Successfully merging this pull request may close these issues.

3 participants

@LuBroering @dennykorsukewitz @rkaldung