Skip to content

Add modules that are shipped with Znuny to list in Environment module. #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
reneeb wants to merge 8 commits into from
Closed

Add modules that are shipped with Znuny to list in Environment module. #87

reneeb wants to merge 8 commits into from

Conversation

@reneeb
Copy link
Contributor

@reneeb reneeb commented Jun 4, 2021

Proposed change

In Kernel::System::Environment there's a list of modules of (some) modules shipped with Znuny. This list is incomplete and this can be annoying (especially if you want to check the module versions with the "new" CPANUpdate command). This change adds all modules that are shipped with Znuny but missing in the list.

Type of change

  • '1 - other'

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy run passes successfully.(❕)
  • Local unit tests pass.(❕)
  • GitHub workflow ZnunyCodePolicy passes.(❗)
  • GitHub workflow unit tests pass.(❗)

@dennykorsukewitz dennykorsukewitz added 1 - 💎 code quality Code quality improvements to existing code or addition of unit tests. 2 - System/Environment 2 - wait for reviewer Znuny, it's your turn. 2 - clarification The issue or pull requests needs more information. labels Jun 15, 2021
@dennykorsukewitz dennykorsukewitz changed the title add modules that are shipped with Znuny to list in Environment module Add modules that are shipped with Znuny to list in Environment module. Jun 15, 2021
@dennykorsukewitz dennykorsukewitz self-assigned this Sep 8, 2022
@dennykorsukewitz dennykorsukewitz removed the 2 - clarification The issue or pull requests needs more information. label Sep 8, 2022
@dennykorsukewitz
Copy link
Member

dennykorsukewitz commented Sep 9, 2022

Hi @reneeb

could you please check this failed UnitTest.

+-------------------------------------------------------------------+
  /opt/otrs/scripts/test/CheckModules.t:
+-------------------------------------------------------------------+
....................................................................................
 not ok 85 - Error in your installed perl modules:   o LWP::Protocol::GHTTP.............FAILED! Not all prerequisites for this module correctly installed.

Thank you 🚀

@dennykorsukewitz dennykorsukewitz added 2 - wait for contributor Contributor, it's your turn. and removed 2 - wait for reviewer Znuny, it's your turn. labels Sep 9, 2022
@dignin
Copy link

dignin commented Jul 12, 2023

@reneeb , do you have any update on this?

@dignin dignin added 3 - wontfix This will not be worked on. and removed 2 - wait for contributor Contributor, it's your turn. labels Apr 15, 2025
@dignin dignin closed this Apr 15, 2025
@dennykorsukewitz dennykorsukewitz deleted the cpan-update/reneeb_add_modules_to_environment branch August 24, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@reneeb reneeb

Labels

1 - 💎 code quality Code quality improvements to existing code or addition of unit tests. 3 - wontfix This will not be worked on.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@reneeb @dennykorsukewitz @dignin