Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR deprecates legacy API components related to certificate compression within the SSL module.
- Deprecates the CertCompressionAlgorithm API in favor of newer alternatives
- Adds deprecation attributes to functions and enums with suggested replacements
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| boring/src/ssl/mod.rs | Added deprecation attributes and updated alternative suggestions for legacy certificate compression APIs |
| boring/src/ssl/cert_compression.rs | Deprecates the CertCompressionAlgorithm enum with an alternative suggestion |
Comments suppressed due to low confidence (1)
boring/src/ssl/cert_compression.rs:9
- The alternative recommended here conflicts with the one in mod.rs; please align the deprecation messages to avoid confusion about which API should be used going forward.
note = "This enum is deprecated and will be removed in a future version. Use `boring::ssl::CertificateCompressionAlgorithm` instead."
Owner
Author
|
Note: In Windows testing, rustup updating the toolchain to version 1.87.0 causes CI to fail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.