Add check for socket errors after poll #1115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to return an error when a connection refused packet is returned from the remote host. As `connect` is called in a non-blocking mode, things like refused connections don't get caught. The subsequent `poll` will just block until the socket is ready, and as it's a file operator it doesn't know/care about refused network connections. Therefore we need to add a check for socket errors after the poll, which should be enough to catch any connection errors.
518bdca to
9b949a8
Compare
Collaborator
|
Should be fixed with e525ce9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
518bdca:
Without this, 3proxy will return a successful connection response if a remote endpoint returned a packet that would normally indicate a failure, such as a connection refused.
I have only tested this change on linux, with tcp connections over socks.
I'm not sure if this will interfere with UDP though.