Update Maybe typing
#325
Merged
Update Maybe typing
#325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Please update the documentation.
Summary:
This PR refactors the Maybe typing in maybe.py to use generic typing, enhancing its flexibility and removing redundant code.
Key points:
- Updated
MaybeBaseclass to use generic typing. - Updated
Maybefunction to return aMaybeBaseof the given type. - Removed inner
MaybeBaseclass definition within theMaybefunction. create_modelfunction now directly returns the new model.
Generated with ❤️ by ellipsis.dev
|
|
||
|
|
||
| def Maybe(model: Type[BaseModel]) -> MaybeBase: | ||
| def Maybe(model: Type[T]) -> Type[MaybeBase[T]]: |
Contributor
There was a problem hiding this comment.
The function signature and implementation have been updated to accept any model that extends BaseModel, but the documentation still refers to BaseModel specifically. Please update the documentation to reflect the changes in the function signature and implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.