release(apps/frontent/line-art-coloring): v0.1.0#95
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the line-art-coloring frontend for its v0.1.0 release by improving error handling around upload history retrieval.
- Ensures
historyresets to an empty array on JSON parse errors instead of silently failing. - Filters out records older than one hour and enforces a maximum of five entries.
| try { | ||
| history = JSON.parse(localStorage.getItem(KEY) || '[]'); | ||
| } catch {} | ||
| } catch { |
There was a problem hiding this comment.
[nitpick] Consider capturing the error object in the catch block and logging it for easier debugging, e.g.: } catch (e) { console.warn('Upload history parse failed:', e); history = []; }
Suggested change
| } catch { | |
| } catch (e) { | |
| console.warn('Upload history parse failed:', e); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.