FeatureIn ProgressSwamp CLI

#1648 Trigger overrides: observability and cleanup follow-ups

Opened by stack72 · 8/14/2026

Follow-ups from PR #2144 review feedback.

Observability (CLI UX Review)

Startup log confirming overrides loaded — Add a line like Loaded N trigger override(s) from serve.yaml after Boot: starting scheduler so users know the config was read without waiting for schedule_registered logs.
Distinguish override from built-in in schedule log — handleScheduleChange logs Registered schedule for workflow {name}: {schedule} for both cases. Add (serve.yaml override) qualifier when resolveSchedule chose the override.
Warn on inputs-only override for unscheduled workflow — An override with only inputs (no schedule) on a workflow that has no built-in schedule is a silent no-op. Log a warning at the end of applyTriggerOverrides.

Cleanup (Code Review / Adversarial Review)

Workflow.withTrigger() is unused in production — Defined and tested (6 tests) but not called in any production code path. Either wire it into #2142 (CLI commands) or remove until needed.
withTrigger bypasses domain validation — Calls the private constructor directly, skipping cron validation. Safe today because serve_config.ts validates upstream, but fragile if called from unvalidated paths. Consider adding validation or documenting the contract.
O(n) linear scan in applyTriggerOverrides — [...this.workflowNames.values()].includes(workflowName) could use a reverse-index Set<string> for O(1) lookup. Negligible at realistic scale.
Remove WHAT comment — // Build trigger overrides map from serve config in serve.ts is self-explanatory.

8/14/2026, 4:44:18 PM

Click a lifecycle step above to view its details.

03Sludge Pulse

stack72 assigned stack728/14/2026, 4:08:59 PM

Finish the swamp_* attribute set on Attio users, and settle the two unprefixed ones (#809 follow-up)

aria-expanded is a raw boolean in 12 places — collapsed state is unannounced to screen readers

Sync every signup to Attio, and backfill the existing population (#809 follow-up)

One standing read: every scalar score consumer reads board_totals, not the ledger

Profile Edit trigger is a fire-and-forget island: no aria-expanded, and a silent no-op if the editor island does not hydrate

Profile XP bar jumps ~25px on fill, and pays the full cumulative walk for two numbers board_totals already holds

Incremental activity projector + swamp.events username bloom index (spun off #925, stages 5+7)

Telemetry stats consumer: insert_id dedup commits before the write it guards — any upsert failure is silently swallowed on retry

score-rollup projector runs N× per cadence — the run gate is per-replica memory, not shared state

Leaderboard board windows re-anchor on wall-clock while the rest of the view is frozen at asOf

Collective management API for extension-based automation

swamp CLI: surface the audience and resolvedInVersion fields swamp-club now serves

Docs: document swamp workflow trigger set/get/remove commands

serve reload should pick up trigger override changes from serve.yaml

Catalog write-lock contention during extension load leaves a partial registry; auto-resolve fabricates 'local edits' and suggests a destructive --force re-pull

Website extension search ignores API relevance — exact name match "good-planning" ranks #10 (API ranks it #1)

Operatives button on Collectives page does nothing

ApiKeyManager's collapsed trigger points aria-controls at an element it never renders

A boolean aria-expanded renders as no aria-expanded: two disclosure widgets report no state to a screen reader

Collective leaderboard: activity metrics aggregated by identity group

Ripple redaction rewrites HTTP status-code runs as phone numbers, silently corrupting evidence

@adam/cfgmgmt/directory: uses GNU stat -c, silently non-compliant on FreeBSD and macOS targets

CLI: swamp workflow trigger set/get/remove commands

Profile score section blocks the render on a ClickHouse read

Plus-addressed emails stripped on invite acceptance, breaking collective join and quest reward

It is possible for a member to be a member of a collective twice

Lab: URLs inside list items aren't clickable (linkified) in rendered issue bodies/summaries

Collective invite emailed-link return path is dropped: /accept-invite sends ?returnUrl= but /login reads ?redirect=

Season Journey card shows "Claim Now" when there are no unclaimed tiers

Clicking username on a quest page opens profile preview modal instead of navigating to the profile

Tell the inviter when a collective invite mis-lands, instead of leaving it pending forever

Ghost profile bypasses the score-read seam and 500s on a slow ledger

A ledger read failure still renders as 'no activity': loadProfileScore swallows to an empty standing behind HTTP 200

Docs: document health monitoring endpoints for swamp serve

Remote trigger override management via --server

feat(serve): headless OAuth client bootstrap via SWAMP_API_KEY

Trigger overrides: observability and cleanup follow-ups

Make model output retention fields optional with sensible defaults

Docs: document trigger overrides in swamp-club manual

Smoke test: gated lab issue lifecycle workflow

Cluster health snapshots with SSE streaming for swamp serve

Docs: document auto-raise of open-file limit in swamp serve reference

Quality rubric + push gate for version upgrade chain correctness

workflow resume truncates the run's log file, losing every earlier attempt's records

Add an upstream-state method: status cannot answer whether commits are pushed

swamp serve dies of descriptor exhaustion on an ordinary workload, having warned about it at startup

extension quality awards repository-verified 2/2 for a nonexistent or private GitHub repo

extension/guide.md quick reference uses -j, which no swamp command accepts

Add a list/discover method to the generated @swamp/aws types — no way to enumerate resources in a region

serve: stale empty directories in active-runs/ never cleaned up

Extension workflows: no way to override trigger configuration

swamp serve: webhook secrets should support @vault= resolution

WebSocket auth rate limiter blocks legitimate users when sharing IP with a failing client

Failing on claude validate

GC expired OAuth server tokens and control plane secrets

Client shows 'Authentication failed' when actually rate-limited

serve: cron ticks leak pending-run records, replaying every past tick on restart

Workers retry forever on permanent auth failures instead of backing off

Remote execution has no working network configuration: off-loopback serve requires TLS, but worker connect cannot connect over TLS

Support --grants-dir for loading grants from a directory

migrate-index still drops shallow-path entries on 2026.08.07.1 — #1584 marked shipped but no released version carries the fix (self-contained repro)

Server token definitions and encryption keys are not durable across pod restarts

data.latest() is memoized per run, contradicting the documented "sees current-run data" contract

Model lookup misreports EMFILE (too many open files) as a broken definition file and dumps a raw stacktrace

Lab Insights not publicly available

Docs: add swamp access group list-idp to access commands reference

serve telemetry identity warnings are diagnostic but not actionable — say how to fix them

swamp quest: drop the heartbeat field the server no longer sends

--grant-reload auto does not detect filesystem changes — blind to ConfigMap updates

Add native Bedrock Knowledge Base Retrieve support

migrate-index silently drops entries with shallow paths — all of workflows-evaluated/ and any root-level file

Add swamp access group list-idp to enumerate IdP groups seen by the server

Grants directory loader skips symlinks — breaks Kubernetes ConfigMap mounts

Daemon telemetry flush: stop() can skip its final flush when a timer drain is already in flight

Docs: `swamp compile` subcommand doesn't exist

Guard the projector's full rewrites against the fail-open lease (ADV-6 from #1575/#1576)

Projector write amplification: board_totals/owner_devices full rewrites are owners × runs/day

Profile candidateIds prune costs a full ledger scan to build itself — 42.88M rows for one keyed read

Leaderboard phase 3: owner-grain board_totals so a cache miss is survivable at 10B

swamp serve is telemetry-dark: scheduled workflow runs never reach /ingest, and the daemon never flushes