Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI 仓库:
felinics/uiAuthor
Type
Summary
修复
<Skeleton>在非黑白灰底面与多色相配色方案下的扫光发灰、盖底问题:--skeleton-mid在浅色模式写死为冷紫灰oklch(0.93 0.002 286),深色模式写死为中性灰oklch(0.315 0 0),在ocean/forest/rose/amber配色方案中未随--scheme-hue覆盖。[data-slot="skeleton"]的扫光渐变两端为不透明var(--muted),会直接盖住元素自身底色;放置在有色表面或传入自定义底色时,会贴出一块不透明死灰条。src/style.css:对齐组件库既有的零色度交互叠色梯(Interaction Overlay Ladder),将--skeleton-mid替换为纯中性零色度半透明 Token--skeleton-bg与--skeleton-shimmer(浅色4.5%黑底 +4.5%黑光带,深色7.5%白底 +6%白光带),并在@theme inline暴露--color-skeleton;[data-slot="skeleton"]渐变两端改为transparent,继续保留background-attachment: fixed与--skeleton-tile的视口锚定跨块同步微光。src/components/skeleton/Skeleton.vue:默认底色改为bg-skeleton,既自动融入任意底层表面色相,也允许调用方通过class覆盖底色并保留上层扫光。showcase/specs/skeleton.ts:补充「有色底面(bg-brand-soft/bg-info-soft/bg-warning-soft)」示例并同步中英文用法说明。Related Issues
Validation
以下为自动检查与 Agent 浏览器自测,不构成真人 QA:
pnpm type-check(vue-tsc --build)通过。scripts/check-ui-contract.mjs规则复核(无组件层裸颜色、手写透明度、任意圆角或阴影),0 违规。http://127.0.0.1:5186/#/components/skeleton,ego-browser,控制台零报错):memoh浅/深色下,计算样式background-color为oklch(0 0 0 / 0.045)(浅)/oklch(1 0 0 / 0.075)(深),background-image两端为transparent,background-attachment: fixed跨块同步微光保持不变。amber(浅)与ocean(深)配色方案,以及在bg-brand-soft/bg-info-soft/bg-warning-soft有色底面容器中,Skeleton 底色与扫光均自然继承底层色相。<div data-slot="skeleton" class="bg-brand-soft">),计算底色保留oklch(0.3 0.07 230 / 0.35)不被覆盖。felinics/Memoh的 submodule gitlink(需本 PR 合并后推进)。Screenshots
Human QA