Repository navigation
Send RDP gateway writes as single TLS records - #487
Merged
Merged
Conversation
With dynamic record sizing, crypto/tls caps the first records of a connection at about 1 KB, which splits the RDS AAD Authentication Request across several records. Windows rejects the split request as invalid (SEC_E_INVALID_TOKEN, 0x80090308).
blakey108
requested review from
miloschwartz and
oschwartz10612
as code owners
November 20, 2026 18:00
Member
|
Sure LGTM thanks |
oschwartz10612
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
AI Disclosure
An AI coding assistant helped me find the cause in a packet capture, write the change and draft this description. I reviewed the change and tested it myself against a Windows 11 host.
Description
The browser gateway's TLS connection to the RDP host uses Go's default dynamic record sizing, which caps the first records of a connection at about 1 KB. That splits a large first write across several TLS records.
RDS AAD Auth (Microsoft Entra ID sign-in,
PROTOCOL_RDSAAD) sends its Authentication Request, about 6.6 KB, as the first client write after the handshake. Windows rejects the request when it arrives in more than one record: RdpCoreTS logs "Authentication Request is invalid" (0x80090308, SEC_E_INVALID_TOKEN) within a millisecond. Microsoft's own clients send it in one record.This sets
DynamicRecordSizingDisabled: trueon that TLS config, so each write goes out as a single record. It only affects record framing on the gateway-to-host connection.Related: fosrl discussion #3388.
How to test?