Repository navigation
Tags
Tags
fix(minimal): the sign-in page's "Change which repositories" link ope… …ns the App's install page (#3590) fix(minimal): link "Change which repositories" to the App install page The settings page lists only personal installations, so a sign-in that reached only organization installations led nowhere useful. The App install page lists every account that has the App. Co-authored-by: minimal-foundry[bot] <327719912+minimal-foundry[bot]@users.noreply.github.com>
feat(minimal): T54 — Every `min box` verb that takes a box completes … …box names (#3509) * feat(minimal): complete box names on every min box verb's box argument Attach the shared completer, now named box_completer, to the box and --parent arguments of the min box verbs. The same arguments back min session logs and min task logs, so those complete box names too (BCLI-028). * test(minimal): drive box completion test with a fixed box list The test compared two empty lists when no daemon ran, so a wrong completer passed. It now serves a fixed box list to the real completer and checks that the reference offers web for w. --------- Co-authored-by: minimal-foundry[bot] <327719912+minimal-foundry[bot]@users.noreply.github.com>
feat: T129 — The daemon stores the expanded spec with each hook's dec… …larer, and composes from it (#3461) * feat(mfile): store lifecycle_hooks with declared_by in the box spec BoxSpec carries the expanded spec's lifecycle hooks, each with the declared_by table that names its declarer (BOX-068, BOX-179). A spec with no hook list writes no key. * feat(minimald): compose the project's hooks from the stored spec The daemon composes the project's lifecycle hooks from the hooks with a project declared_by in spec.json, in place of the [session] hooks of minimal.toml and the hooks of the expanded entry (BOX-068, BOX-179). A loadout hook still arrives on the contribution with its loadout. The log line that stores the spec names how many hooks it carries. * feat(minimal): send the expanded hooks with their declarers on the spec A session create puts the expanded spec's lifecycle_hooks, each with its declared_by, into the box spec it sends. The daemon stores them in spec.json and composes the project's hooks from them (BOX-068, BOX-179). * fix(minimald): fail the compose when the stored spec cannot be read A box that stores spec.json no longer falls back to the hooks in minimal.toml when the file exists but cannot be read. * test(minimald): use expect_err for the unreadable spec case * fix(minimald): refuse a stored spec the launch refuses at compose A spec.json that is not a v0 spec, or has a hook with no valid declared_by, now fails the compose with the InvalidInput refusal that held_spec gives at launch, in place of a fall back to minimal.toml. * fix(minimald): compose reads only the stored spec keys it uses The compose parsed the whole spec.json as a v0 Box Spec. A stored spec can carry keys that parse refuses, such as io.exec_enabled, file_exports and network.vpn_network_names, and partial specs. The compose now reads v, entry, box.type and lifecycle_hooks, and refuses only a spec that is not JSON or a hook list it cannot use. --------- Co-authored-by: minimal-foundry[bot] <327719912+minimal-foundry[bot]@users.noreply.github.com>
fix(boxes): T51 — The Box Egress Proxy refusals name the minimal.toml… … tables (#3433) * fix(boxes): name the minimal.toml table in each BEP refusal The Box Egress Proxy refusals and the -o json hint now name [defaults.session.network.bep] or [defaults.session.secrets] in minimal.toml, where the setting loads today. The grant refusals of min box create, the pinned tests and the e2e hint read the new text. * style(boxes): format the BEP refusal table test * fix(boxes): take the minimal.toml table as a field of each BEP refusal The refusals and the un-enrolled next step named a fixed [defaults.session.*] table. min box spec <entry> previews the same refusals for a spec expanded from every layer, so the table now comes from the spec's BepTables. * fix(minimal): name the layer that set secrets in min box spec refusals min box start passes [defaults.session.secrets] and [defaults.session.network.bep], so its text does not change. min box spec <entry> passes the table of the layer that set secrets or network, such as [tasks.ci.secrets]. * fix(boxes): let the un-enrolled refusal name no table unenrolled_node takes the minimal.toml table that set the grants. A caller that cannot know it passes None, and the text names the secrets of the box's entry. A non-table source reads without 'in minimal.toml'. * fix(minimald): name no table in the un-enrolled refusal The daemon gets a spec from any entry, and not the table that set its secrets, so its refusal names the secrets of the box's entry. min box start reads the grants from [defaults.session] and passes that table. * fix(minimal): name a loadout or the command line in box spec refusals A value from a selected loadout or a flag sits above the entry, so an edit to the entry's table does not change it. * test(boxes): split the un-enrolled table test under the line limit --------- Co-authored-by: minimal-foundry[bot] <327719912+minimal-foundry[bot]@users.noreply.github.com>
test(mfile): T27 — Pin golden vectors for the example and the built-i… …n types (#3439) * test(mfile): pin golden vectors for the example and the built-in types The session and task entries of the example minimal.toml, and the implicit default entry of a file with only [defaults.session], expand to spec bytes and projection digests pinned in vectors.json. The six built-in types render their defaults and constraints equal to theirs. A failing vector names itself and the first byte that differs (BOX-145). * test(mfile): pin golden vectors to the design's example Replace the reconstructed example.toml with a byte copy of example-minimal.toml from gominimal/arch at 15b603e6, require the dev and render-diagrams vectors, check that reviewer, nightly and docs-preview do not expand, and bless vectors.json again. * test(mfile): read built-in roots through BoxTypes::root The root vector called box_types::builtin, which echoes its argument, and hid a missing type behind an empty string. A default BoxTypes resolves the root the way a file with no [box_types] does. --------- Co-authored-by: minimal-foundry[bot] <327719912+minimal-foundry[bot]@users.noreply.github.com>
fix(minimal): T52 — A terminal exec's mode is `tty` everywhere (#3434) fix(minimal): name a terminal exec's mode tty in min box show The Live execs row and the min/v1/exec object said terminal, while the exec_started event and min box exec --tty say tty. Use tty everywhere, and pin it with exec_mode_is_one_word_in_show_and_events. Co-authored-by: minimal-foundry[bot] <327719912+minimal-foundry[bot]@users.noreply.github.com>
feat(minimald): T44 — Detach from an exec attach with the detach keys (… …#3341) * feat(minimald): end an exec attach on the detach keys serve_exec_attach now runs the leader and detach state machine of the box's own terminal, with the keys the channel negotiated. A detach ends the channel with status 0 and leaves the exec running (BCLI-068). * style(minimald): format the exec attach detach test * feat(minimal): send the session keys on an exec attach min box attach <box> --exec <id> now sends the session keys from the config, as the box attach does, so the daemon detaches on them (BCLI-068). * test(minimald): spawn the detach test's attaches through traced * fix(minimald): bound the exec attach's detach notice and bell writes A client that does not read held the detach on the notice write. The writes now wait at most EXIT_NOTICE_BOUND, and the detach goes on. * fix(minimal): send the session keys on min box exec -t's attach The first terminal attach of min box exec -t sent no keys, so a remapped leader or detach key did not apply. It now builds its ssh command through exec_attach_ssh, as min box attach --exec does. * test(minimal): pin the session keys on min box exec -t's attach The ssh that min box exec -t's first attach runs now comes from exec_terminal_ssh. A test checks that, with detach = "q" configured, it carries the leader and detach env vars and their SendEnv options. * fix(minimal): resolve exec -t's session keys before the exec starts A session-key config that is not valid now ends min box exec -t with no exec started, not with a running exec that has no attach. * docs(minimal): say the wire attach path sends no session keys * fix(minimald): ring the exec leader bell without a wait An awaited bell parked the exec attach relay for up to 5 s per leader press behind a client that does not read. The bell now goes only when the client has room for it. The detach notice waits at most the 2 s host probe bound, as the box terminal's detach does. --------- Co-authored-by: minimal-foundry[bot] <327719912+minimal-foundry[bot]@users.noreply.github.com>
T23 — Check type constraints last, and let a derived type only narrow (… …#3292) * feat(mfile): check Box Type constraints last, and only narrow A type's constraints are a check, never a layer. check_constraints reads a finished expansion, after the override layer, and fails with exit 3 naming the type, the key and the layer that set the value (BOX-061). It never changes the spec, so a constraint never adds a package, a port or an egress entry (BOX-062). Type resolution fails with exit 3 naming the type, the key and the parent when a derived type's constraint admits a value its parent's excludes (BOX-156). * fix(mfile): name the type that holds the broken constraint check_constraints named the entry's own type for every failure, even when the failing constraint came from a parent type. Check the entry's type first and name the type whose constraints table failed. * fix(mfile): seed built-in constraints and check section keys Each built-in Box Type now ships its constraints, so a project type cannot loosen them and an entry of the type is checked against them. A constrained setting is checked at its flat key and under its section, with the section map taken from spec.rs. * docs(mfile): note that no create path calls check_constraints yet #3295 adds the call after each expand on the create path. * fix(mfile): keep both forms of a constrained key when narrowing A type that set a key flat and under its section was checked against itself, and only its last form reached the types that extend it. Check each type only against the types before it, and keep every form. --------- Co-authored-by: minimal-foundry[bot] <327719912+minimal-foundry[bot]@users.noreply.github.com>
T21 — One minimal.toml for every box, end to end (#3244) * feat(boxes): compose the project from the expanded entry The contribution carries the expanded minimal.toml entry, and the daemon composer applies each list it carries. A list the entry leaves out keeps the daemon's own project items of that kind (BOX-068). * feat(minimal): send the expanded entry when a box starts Session and task starts expand their minimal.toml entry over [defaults] and [defaults.<type>], with a legacy [session] table read as [defaults.session], and send it on the contribution. The daemon composes the project's part of each box from it (BOX-068). * fix(minimald): compose an entry box without reading [session] When the client sends an expanded entry, build_composables no longer reads the project's [session] table, so a task box gets none of it. Entry packages join the closure walk, so their env_state_wiring and fs mappings compose. The wire docs state that the entry carries only the five composed lists, and name #3257 for the full expanded spec. * style(minimald): format the entry wiring test * fix(minimal): refuse a start whose session entry is undecided session_box_entry now returns the SessionEntryUndecided refusal in place of sending no entry, so the start never falls back to [session]. The end-to-end test also starts a task entry in a legacy [session] project and checks that the task gets no vars, and checks the refusal. * docs(minimal): say a task entry's vars and patches do not reach the box The box_entry doc comment claimed that min task run applies a task entry's vars and patches. It reads only the [tasks.<name>] table, so the [defaults] layers are dropped. Name issue #3266 for that gap. --------- Co-authored-by: minimal-foundry[bot] <327719912+minimal-foundry[bot]@users.noreply.github.com>
PreviousNext