Skip to content

Clarify token exchange after revoking an ancestor access token - #53770

Open
Oluwatobi-Mustapha wants to merge 1 commit into
keycloak:mainfrom
Oluwatobi-Mustapha:clarify-exchange-revocation
Open

Oluwatobi-Mustapha wants to merge 1 commit into
keycloak:mainfrom
Oluwatobi-Mustapha:clarify-exchange-revocation

Conversation

@Oluwatobi-Mustapha

@Oluwatobi-Mustapha Oluwatobi-Mustapha commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Closes #51633

Clarify that a still-valid exchanged access token can be exchanged again after an earlier access token in the chain is revoked. This documents the existing behaviour and leaves the separate refresh-token guidance unchanged.

@Oluwatobi-Mustapha
Oluwatobi-Mustapha requested a review from a team as a code owner October 9, 2026 05:23
Copilot AI balanced review requested due to automatic review settings October 9, 2026 05:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation accurately describes existing behavior and maintains the access-token versus refresh-token distinction.

0 open findings

What changed in this PR

Clarifies non-cascading access-token revocation behavior in token exchange documentation.

Changes:

  • Documents that a valid descendant access token remains exchangeable after its ancestor is revoked.
  • Preserves separate refresh-token revocation-chain guidance.
File Description
docs/​guides/​securing-apps/​token-exchange.adoc Clarifies access-token exchange behavior after ancestor revocation.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@lhanusov

Copy link
Copy Markdown
Contributor

@graziang can you please review this PR? thanks

@jimmychakkalakal jimmychakkalakal self-assigned this Nov 16, 2026
@jimmychakkalakal

Copy link
Copy Markdown
Contributor

I took a look at the PR. The documentation change looks clear and addresses the clarification requested in #51633. The existing section (https://www.keycloak.org/securing-apps/token-exchange#revocation) already explains that revocation does not cascade between access tokens; this addition explicitly states that a valid exchanged access token can still be exchanged again after its ancestor is revoked.

@graziang, I’d appreciate your thoughts on this.

@jimmychakkalakal jimmychakkalakal removed their assignment Nov 16, 2026

@graziang graziang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Oluwatobi-Mustapha thanks, just added an inline comment, can you please check?

Closes keycloak#51633

Signed-off-by: Oluwatobi Mustapha <oluwatobimustapha539@gmail.com>
@Oluwatobi-Mustapha
Oluwatobi-Mustapha force-pushed the clarify-exchange-revocation branch from 140af52 to 2727ced Compare November 19, 2026 10:07
Copilot AI balanced review requested due to automatic review settings November 19, 2026 10:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the documentation clarification on descendant-token exchanges after ancestor revocation.

No open issues 🎉

Review effort: Balanced

@graziang graziang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Token exchange: a revoked chain can still be extended into a new token

5 participants