Repository navigation
Clarify token exchange after revoking an ancestor access token - #53770
Oluwatobi-Mustapha wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The documentation accurately describes existing behavior and maintains the access-token versus refresh-token distinction.
0 open findings
What changed in this PR
Clarifies non-cascading access-token revocation behavior in token exchange documentation.
Changes:
- Documents that a valid descendant access token remains exchangeable after its ancestor is revoked.
- Preserves separate refresh-token revocation-chain guidance.
| File | Description |
|---|---|
docs/guides/securing-apps/token-exchange.adoc |
Clarifies access-token exchange behavior after ancestor revocation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@graziang can you please review this PR? thanks |
|
I took a look at the PR. The documentation change looks clear and addresses the clarification requested in #51633. The existing section (https://www.keycloak.org/securing-apps/token-exchange#revocation) already explains that revocation does not cascade between access tokens; this addition explicitly states that a valid exchanged access token can still be exchanged again after its ancestor is revoked. @graziang, I’d appreciate your thoughts on this. |
graziang
left a comment
There was a problem hiding this comment.
@Oluwatobi-Mustapha thanks, just added an inline comment, can you please check?
Closes keycloak#51633 Signed-off-by: Oluwatobi Mustapha <oluwatobimustapha539@gmail.com>
140af52 to
2727ced
Compare
graziang
left a comment
There was a problem hiding this comment.
@Oluwatobi-Mustapha thanks!
Closes #51633
Clarify that a still-valid exchanged access token can be exchanged again after an earlier access token in the chain is revoked. This documents the existing behaviour and leaves the separate refresh-token guidance unchanged.