Skip to content

Fix partial component updates without provider metadata - #54636

Open
gibkim wants to merge 1 commit into
keycloak:mainfrom
gibkim:fix-component-partial-update-54504
Open

gibkim wants to merge 1 commit into
keycloak:mainfrom
gibkim:fix-component-partial-update-54504

Conversation

@gibkim

@gibkim gibkim commented Nov 4, 2026 •

Copy link
Copy Markdown

Closes #54504

Decisions and assumptions:

An AI agent generated the implementation and tests.

Closes keycloak#54504

Signed-off-by: gibKim <gbkim0909@gmail.com>
@gibkim
gibkim requested a review from a team as a code owner November 4, 2026 11:39
Copilot AI balanced review requested due to automatic review settings November 4, 2026 11:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the partial component update fix.

No open issues 🎉

What changed in this PR

Fixes partial component updates that return HTTP 500 when provider metadata is omitted, addressing #54504 while preserving configuration merging and admin-event secret masking.

Changes:

  • Fills missing provider fields from the merged component before generating the admin event.
  • Adds regression coverage for omitted provider fields and configuration, retained values, and secret masking.
File Description
tests/​base/​src/​test/​java/​org/​keycloak/​tests/​admin/​ComponentsTest.java Tests partial updates, configuration retention, and admin-event secret masking.
services/​src/​main/​java/​org/​keycloak/​services/​resources/​admin/​ComponentResource.java Supplies omitted provider metadata before admin-event generation.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Component update without providerType crashes with a 500

3 participants