Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The formatting command omits the distribution and operator modules, and the test rule conflicts with the documented exception for regression cases in existing tests.
2 open issues
What changed in this PR
This PR streamlines Keycloak’s Copilot guidance, separating code-review policies from cloud-agent instructions and deferring to canonical contributor documentation.
Changes:
- Replaces detailed toolchain and workflow guidance with documentation links and shorter commands.
- Adds explicit review checks for testing, contribution requirements, AI disclosure, and security reporting.
- Retains concise, high-confidence review standards.
| File | Description |
|---|---|
.github/copilot-instructions.md |
Reorganizes and simplifies review policies and cloud-agent guidance. |
Review effort: Balanced
5a0136e to
124da16
Compare
ahus1
left a comment
There was a problem hiding this comment.
Happy go give this variant a try. Note below: Maybe the final block can move to AGENTS.md?
| * Use the Maven Wrapper (`./mvnw`), not system Maven. Build setup and toolchain versions are in `docs/building.md`. | ||
| * Keep changes focused. Do not refactor or reformat unrelated code. | ||
| * Include tests and docs when behavior changes. | ||
| * New integration tests go in `tests/` (see `tests/docs/README.md`), never in `testsuite/`. Do not introduce new test frameworks or mocks (see `docs/tests-development.md`). |
There was a problem hiding this comment.
Could this move to the AGENTS.md ?
There was a problem hiding this comment.
I'll update with any duplication removed.
There was a problem hiding this comment.
Updated - we won't have any special cloud agent instructions here if / until we start using the copilot feature more around opening PRs and find gaps with what it is not following vs the AGENTS.md.
closes: keycloak#54772 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
9a8a6d4 to
7497d30
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The instructions omit exceptions to the issue requirement and incorrectly prohibit all mocks rather than mocking frameworks, risking false-positive findings and unnecessary testing restrictions.
2 open issues
Review effort: Balanced
Updated guidelines for PR requirements and test frameworks. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Steven Hawkins <shawkins@redhat.com>
closes: #54772
updated to see if we can get it to emit more high and medium findings per review.