Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The favicon fallback bypasses existing login-theme overrides, causing custom themes without a favicons property to display the common Keycloak icon instead of their own.
1 open issue
What changed in this PR
Unifies the welcome page with the keycloak.v3 login theme, reducing duplicated templates and aligning styling and spacing with the goals of #55313 and #51619.
Changes:
- Reuses login layouts, form controls, branding, and resources for the welcome page.
- Adds login-theme fallback for welcome theme resolution while retaining custom
welcome/index.ftlsupport. - Removes standalone welcome assets and updates tests and migration documentation.
| File | Description |
|---|---|
| themes/src/main/resources/theme/keycloak/welcome/theme.properties | Removes standalone welcome configuration. |
| themes/src/main/resources/theme/keycloak/welcome/theme-resources.ftl | Removes duplicated resource macros. |
| themes/src/main/resources/theme/keycloak/welcome/resources/logo.svg | Removes standalone welcome logo. |
| themes/src/main/resources/theme/keycloak/welcome/resources/css/welcome.css | Removes welcome-specific styles. |
| themes/src/main/resources/theme/keycloak/welcome/resources/background.svg | Removes standalone background artwork. |
| themes/src/main/resources/theme/keycloak/welcome/messages/messages_en.properties | Removes obsolete English theme description. |
| themes/src/main/resources/theme/keycloak/welcome/index.ftl | Removes the duplicated welcome template. |
| themes/src/main/resources/theme/keycloak.v3/login/theme.properties | Adds welcome header styling and redirect configuration. |
| themes/src/main/resources/theme/base/login/welcome.ftl | Adds welcome content using shared macros. |
| themes/src/main/resources/theme/base/login/template.ftl | Extracts a shared layout usable without a realm. |
| themes/src/main/resources/theme/base/login/messages/messages_en.properties | Adds welcome-page messages. |
| themes/src/main/resources/theme/base/login/field.ftl | Supports configurable input types. |
| themes/src/main/resources/META-INF/keycloak-themes.json | Removes standalone welcome theme registration. |
| themes/src/main/resources-community/theme/keycloak/welcome/messages/messages_vi.properties | Removes obsolete Vietnamese theme description. |
| themes/src/main/resources-community/theme/keycloak/welcome/messages/messages_tr.properties | Removes obsolete Turkish theme description. |
| themes/src/main/resources-community/theme/keycloak/welcome/messages/messages_sv.properties | Removes obsolete Swedish theme description. |
| themes/src/main/resources-community/theme/keycloak/welcome/messages/messages_pt_BR.properties | Removes obsolete Brazilian Portuguese theme description. |
| themes/src/main/resources-community/theme/keycloak/welcome/messages/messages_ka.properties | Removes obsolete Georgian theme description. |
| themes/src/main/resources-community/theme/keycloak/welcome/messages/messages_id.properties | Removes obsolete Indonesian theme description. |
| themes/src/main/resources-community/theme/keycloak/welcome/messages/messages_hu.properties | Removes obsolete Hungarian theme description. |
| themes/src/main/resources-community/theme/keycloak/welcome/messages/messages_fa.properties | Removes obsolete Persian theme description. |
| themes/src/main/resources-community/theme/keycloak/welcome/messages/messages_de.properties | Removes obsolete German theme description. |
| themes/src/main/resources-community/theme/keycloak/welcome/messages/messages_cs.properties | Removes obsolete Czech theme description. |
| themes/src/main/resources-community/theme/keycloak/welcome/messages/messages_ca.properties | Removes obsolete Catalan theme description. |
| testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/theme/ThemeResourceProviderTest.java | Uses login assets in resource-serving tests. |
| testsuite/integration-arquillian/tests/base/src/main/java/org/keycloak/testsuite/auth/page/WelcomePage.java | Updates legacy welcome-page selectors. |
| tests/base/src/test/java/org/keycloak/tests/welcomepage/WelcomePageTest.java | Checks shared resources and realm-free inheritance. |
| test-framework/ui/src/main/java/org/keycloak/testframework/ui/page/WelcomePage.java | Updates selectors for shared controls. |
| services/src/main/java/org/keycloak/theme/DefaultThemeManager.java | Supports welcome-to-login theme fallback and inheritance. |
| services/src/main/java/org/keycloak/services/resources/WelcomeResource.java | Supplies shared-template data and selects the welcome template. |
| server-spi/src/main/java/org/keycloak/theme/ThemeSelectorProvider.java | Defaults welcome themes to keycloak.v3. |
| docs/guides/ui-customization/welcome-theme.adoc | Documents welcome customization and inheritance. |
| docs/documentation/upgrading/topics/changes/changes-27_0_0.adoc | Explains migration from the standalone welcome theme. |
| docs/documentation/release_notes/topics/27_0_0.adoc | Describes the shared login and welcome UI. |
Review effort: Balanced
Closes keycloak#55313 Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.federation.ldap.LDAPSearchForUsersPaginationTest#testSearchLDAPMatchesLocalDBDefaultPrefixSearch |
kathari00
reviewed
Nov 18, 2026
kathari00
reviewed
Nov 18, 2026
Signed-off-by: Martin Bartoš <mabartos@redhat.com>
kathari00
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UI is consistent with the Login UI:

@edewit @vaceksimon @kathari00 Could you please check it? Thanks!