Skip to content

Default welcome theme extends new login theme - #55315

Open
mabartos wants to merge 2 commits into
keycloak:mainfrom
mabartos:KC-55313
Open

mabartos wants to merge 2 commits into
keycloak:mainfrom
mabartos:KC-55313

Conversation

@mabartos

@mabartos mabartos commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

@mabartos
mabartos requested review from a team as code owners November 18, 2026 14:51
Copilot AI balanced review requested due to automatic review settings November 18, 2026 14:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The favicon fallback bypasses existing login-theme overrides, causing custom themes without a favicons property to display the common Keycloak icon instead of their own.

1 open issue
What changed in this PR

Unifies the welcome page with the keycloak.v3 login theme, reducing duplicated templates and aligning styling and spacing with the goals of #55313 and #51619.

Changes:

  • Reuses login layouts, form controls, branding, and resources for the welcome page.
  • Adds login-theme fallback for welcome theme resolution while retaining custom welcome/index.ftl support.
  • Removes standalone welcome assets and updates tests and migration documentation.
File Description
themes/​src/​main/​resources/​theme/​keycloak/​welcome/​theme.properties Removes standalone welcome configuration.
themes/​src/​main/​resources/​theme/​keycloak/​welcome/​theme-resources.ftl Removes duplicated resource macros.
themes/​src/​main/​resources/​theme/​keycloak/​welcome/​resources/​logo.svg Removes standalone welcome logo.
themes/​src/​main/​resources/​theme/​keycloak/​welcome/​resources/​css/​welcome.css Removes welcome-specific styles.
themes/​src/​main/​resources/​theme/​keycloak/​welcome/​resources/​background.svg Removes standalone background artwork.
themes/​src/​main/​resources/​theme/​keycloak/​welcome/​messages/​messages_en.properties Removes obsolete English theme description.
themes/​src/​main/​resources/​theme/​keycloak/​welcome/​index.ftl Removes the duplicated welcome template.
themes/​src/​main/​resources/​theme/​keycloak.v3/​login/​theme.properties Adds welcome header styling and redirect configuration.
themes/​src/​main/​resources/​theme/​base/​login/​welcome.ftl Adds welcome content using shared macros.
themes/​src/​main/​resources/​theme/​base/​login/​template.ftl Extracts a shared layout usable without a realm.
themes/​src/​main/​resources/​theme/​base/​login/​messages/​messages_en.properties Adds welcome-page messages.
themes/​src/​main/​resources/​theme/​base/​login/​field.ftl Supports configurable input types.
themes/​src/​main/​resources/​META-INF/​keycloak-themes.json Removes standalone welcome theme registration.
themes/​src/​main/​resources-community/​theme/​keycloak/​welcome/​messages/​messages_vi.properties Removes obsolete Vietnamese theme description.
themes/​src/​main/​resources-community/​theme/​keycloak/​welcome/​messages/​messages_tr.properties Removes obsolete Turkish theme description.
themes/​src/​main/​resources-community/​theme/​keycloak/​welcome/​messages/​messages_sv.properties Removes obsolete Swedish theme description.
themes/​src/​main/​resources-community/​theme/​keycloak/​welcome/​messages/​messages_pt_BR.properties Removes obsolete Brazilian Portuguese theme description.
themes/​src/​main/​resources-community/​theme/​keycloak/​welcome/​messages/​messages_ka.properties Removes obsolete Georgian theme description.
themes/​src/​main/​resources-community/​theme/​keycloak/​welcome/​messages/​messages_id.properties Removes obsolete Indonesian theme description.
themes/​src/​main/​resources-community/​theme/​keycloak/​welcome/​messages/​messages_hu.properties Removes obsolete Hungarian theme description.
themes/​src/​main/​resources-community/​theme/​keycloak/​welcome/​messages/​messages_fa.properties Removes obsolete Persian theme description.
themes/​src/​main/​resources-community/​theme/​keycloak/​welcome/​messages/​messages_de.properties Removes obsolete German theme description.
themes/​src/​main/​resources-community/​theme/​keycloak/​welcome/​messages/​messages_cs.properties Removes obsolete Czech theme description.
themes/​src/​main/​resources-community/​theme/​keycloak/​welcome/​messages/​messages_ca.properties Removes obsolete Catalan theme description.
testsuite/​integration-arquillian/​tests/​base/​src/​test/​java/​org/​keycloak/​testsuite/​theme/​ThemeResourceProviderTest.java Uses login assets in resource-serving tests.
testsuite/​integration-arquillian/​tests/​base/​src/​main/​java/​org/​keycloak/​testsuite/​auth/​page/​WelcomePage.java Updates legacy welcome-page selectors.
tests/​base/​src/​test/​java/​org/​keycloak/​tests/​welcomepage/​WelcomePageTest.java Checks shared resources and realm-free inheritance.
test-framework/​ui/​src/​main/​java/​org/​keycloak/​testframework/​ui/​page/​WelcomePage.java Updates selectors for shared controls.
services/​src/​main/​java/​org/​keycloak/​theme/​DefaultThemeManager.java Supports welcome-to-login theme fallback and inheritance.
services/​src/​main/​java/​org/​keycloak/​services/​resources/​WelcomeResource.java Supplies shared-template data and selects the welcome template.
server-spi/​src/​main/​java/​org/​keycloak/​theme/​ThemeSelectorProvider.java Defaults welcome themes to keycloak.v3.
docs/​guides/​ui-customization/​welcome-theme.adoc Documents welcome customization and inheritance.
docs/​documentation/​upgrading/​topics/​changes/​changes-27_0_0.adoc Explains migration from the standalone welcome theme.
docs/​documentation/​release_notes/​topics/​27_0_0.adoc Describes the shared login and welcome UI.

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 18, 2026 15:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the change unifying the welcome and login pages around keycloak.v3.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 18, 2026 15:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the welcome and login theme unification.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 18, 2026 15:32
Closes keycloak#55313

Signed-off-by: Martin Bartoš <mabartos@redhat.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues blocking the change that unifies the welcome and login themes.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 18, 2026 15:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the welcome and login theme consolidation.

No open issues 🎉

Review effort: Balanced

@keycloak-github-bot keycloak-github-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot

Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.federation.ldap.LDAPSearchForUsersPaginationTest#testSearchLDAPMatchesLocalDBDefaultPrefixSearch

Keycloak CI - Base IT (5)

java.lang.AssertionError: 

Expected: iterable with items ["john", "john00", "john01", "john02", "john03", "john04", "john05", "john06", "john07", "john08", "john09", "john11", "john12"] in any order
     but: no match for: "john10"
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
...

Report flaky test

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Copilot AI balanced review requested due to automatic review settings November 19, 2026 10:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the welcome and login theme unification.

No open issues 🎉

Review effort: Balanced

@mabartos
mabartos requested a review from kathari00 November 19, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default welcome theme extends new login theme

3 participants