fix: relax stub .gz linting regex to accept echo without arguments#4323
Open
handsomesix wants to merge 2 commits into
Open
fix: relax stub .gz linting regex to accept echo without arguments#4323handsomesix wants to merge 2 commits into
handsomesix wants to merge 2 commits into
Conversation
Contributor
This PR is against the
|
1fbb006 to
6391130
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4231 by relaxing the stub .gz linting regex to make the echo argument optional.
Changes
echo,echo '', andecho ""as valid arguments before piping to gzip.echo ""was accepted;echo | gzip >now also passes lint.Tests
Verified that existing valid patterns continue to pass and that invalid syntax (touch, non-empty echo strings) is still correctly flagged.
Risk
Low. The change only broadens an existing regex match — it does not affect any other lint rule or module behavior.