libs/aegra-api/src/aegra_api/services/assistant_service.py (5)

618-631: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Same issue: read filters discarded.

Apply the filters returned by _dispatch("read", ...) to the query, consistent with get_assistant.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@libs/aegra-api/src/aegra_api/services/assistant_service.py` around lines 618
- 631, The query in get_assistant_subgraphs ignores the access-control filters
returned by await self._dispatch("read", {"assistant_id": assistant_id}); modify
get_assistant_subgraphs to capture the dispatch result (like in get_assistant),
extract and apply its returned filters/where-clause to the select(AssistantORM)
statement (or combine with existing where conditions) so the same access filters
from _dispatch("read", ...) are honored before calling self.session.scalar;
reference the get_assistant_subgraphs method and the _dispatch("read", ...) call
and follow the pattern used in get_assistant.

---

436-439: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Guard against None after re-fetch.

After the UPDATE, session.scalar(stmt) may return None from the type checker's perspective. Add an assertion or raise to satisfy the type checker and catch any unexpected state.

🔧 Proposed fix

         await self.session.execute(assistant_update)
         await self.session.commit()
         updated_assistant = await self.session.scalar(stmt)
+        assert updated_assistant is not None, "Assistant disappeared after update"
         return to_pydantic(updated_assistant)

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@libs/aegra-api/src/aegra_api/services/assistant_service.py` around lines 436
- 439, After executing the UPDATE and re-fetching with session.scalar(stmt) in
the assistant service method, guard against a None result by asserting or
raising if updated_assistant is None so the type checker and runtime are
satisfied; update the block that calls await
self.session.execute(assistant_update), await self.session.commit(), and
updated_assistant = await self.session.scalar(stmt) to check updated_assistant
(e.g., raise RuntimeError or AssertionError with a clear message including the
assistant id/context) before returning to_pydantic(updated_assistant).

---

530-543: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Handle potentially None version name.

v.name may be None (per pipeline error), but Assistant.name requires str. Provide a fallback.

🔧 Proposed fix

         version_list = [
             Assistant(
                 assistant_id=assistant_id,
-                name=v.name,
+                name=v.name or "",
                 description=v.description,
                 config=v.config or {},
                 context=v.context or {},

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@libs/aegra-api/src/aegra_api/services/assistant_service.py` around lines 530
- 543, The Assistant construction in version_list can pass None for v.name which
violates Assistant.name's str requirement; update the Assistant(...) call (in
the version_list creation) to provide a fallback string when v.name is None
(e.g., use v.name or f"unnamed-{v.version}" or a fixed "<unnamed>" value) so
Assistant.name always receives a str; keep the rest of the fields unchanged and
ensure any chosen fallback is descriptive for debugging.

---

185-198: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Fix type errors: config may be None.

The pipeline failures indicate that request.config can be None, making config.get("configurable") and subscript operations fail type checking. Default to an empty dict.

🔧 Proposed fix

-        config = request.config
-        context = request.context
+        config = request.config or {}
+        context = request.context or {}
 
-        if config.get("configurable") and context:
+        if config.get("configurable") and context:

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@libs/aegra-api/src/aegra_api/services/assistant_service.py` around lines 185
- 198, request.config can be None causing attribute/subscript errors; default
config to an empty dict and ensure any updates are written back to
request.config. Concretely, replace use of config = request.config with config =
request.config or {} (or equivalent null-coalescing), then keep the same checks
(config.get("configurable")) and assignments, and when you set
config["configurable"] = context make sure to assign the modified dict back to
request.config so the request object is updated.

---

496-499: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Same None guard needed after re-fetch.

Same pattern as update_assistant — add assertion after re-fetching the updated row.

🔧 Proposed fix

         await self.session.execute(assistant_update)
         await self.session.commit()
         updated_assistant = await self.session.scalar(stmt)
+        assert updated_assistant is not None, "Assistant disappeared after update"
         return to_pydantic(updated_assistant)

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@libs/aegra-api/src/aegra_api/services/assistant_service.py` around lines 496
- 499, After re-fetching the updated row using updated_assistant = await
self.session.scalar(stmt) add the same None-guard/assertion used in
update_assistant: verify updated_assistant is not None (raise an appropriate
exception or assert) before calling to_pydantic(updated_assistant). Locate the
re-fetch and return sequence (the self.session.scalar(stmt) call, the
updated_assistant variable, and the to_pydantic call) and insert the null-check
to avoid passing None into to_pydantic.