Repository navigation
Feedback about the pull request experience #255
Description
Activity
Hey there! Small feedback from me: linking an issue in codecov comment resulted with quite unexpected result:
I could barely load this issue as GH was timing out on me 😅 maybe you can wrap link to the issue with in some sort of redirect on your end? (I dunno
gh-feedback.codecov.ioor whatever so it would not be auto-linked by github 🫠)edit: I could also barely add this comment, obviously unsubscribing here as it would flood my inbox
Reacted by Lucas Garron and Paul LoydI could barely load this issue as GH was timing out on me 😅 maybe you can wrap link to the issue with in some sort of redirect on your end? (I dunno
gh-feedback.codecov.ioor whatever so it would not be auto-linked by github 🫠)I think this would be a good idea. It took me a whole bunch of tries to load this issue.
As for actual feedback:
My experience is that
codecovmarked one of my PRs as decreasing test coverage, when test coverage actually increased.8 covered lines were replaced by 14 covered lines. And those 14 lines are definitely covered, because they required updates to tests to exercise two separate code paths.
5 lines of indirect changes are reported, but this should still not cause a decrease in overall coverage percentage. And it still doesn't explain why the Patch % is listed as 0.00%.
So my overall experience is that this is worse than useless. I had to spend some time trying to figure out what's going on, only to come to the conclusion that either:
- The code coverage measurement is as broken as it could possibly be.
- I should be receiving some context to interpret what's going on, but I'm not.
I want a better view of the coverage directly in my PR. See this Github issue which describes the issue perfectly: codecov/codecov-action#738
I don't want to have to open a new tab and go look at some other application to figure out what the coverage is. It should be able to tell me right away in its comment to save me time and effort.
Reacted by Stefan WrobelHi, I checked the docs and could not find where to configure this. I like Codecov as a FOSS maintainer to give me a view of the coverage change in each PR, but the current PR comment is pretty aggressive to my contributors. Would it be possible to change the
❌ Patch coverage is 65.72770% with 73 lines in your changes missing coverage. Please review.to more of a sidenote than what it currently suggests ? I want to see it, but I don't want contributors to feel like they need to increase coverage to mergeIts federation level good work if you need federation level advice don't be shy
Unable to view uncovered lines sometimes for this report: https://app.codecov.io/gh/Zoo-Code-Org/Zoo-Code/pull/834?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Zoo-Code-Org
Thanks for dropping by! 👋
We'd love your feedback about the pull request comment, focused on the comment report details, layout, and information presented.
-
What do you like about the PR comment report?
-
What would you'd like to see improved?
-
What are challenges or frustrations you've experienced?
-
How do you use the comment today?
-
How could the report better help your workflow?
Any general thoughts you'd like to share! We greatly appreciate your time and thoughts - looking forward to hearing from you ❤
Codecov team
This issue is intended to share and collect feedback about the tool. If you have support needs or questions, please see our support page.
-
Perfect
Metadata
Metadata
Assignees
Type
Projects
- Status
Thanks for dropping by! 👋
We'd love your feedback about the pull request comment, focused on the comment report details, layout, and information presented.
Any general thoughts you'd like to share! We greatly appreciate your time and thoughts - looking forward to hearing from you ❤
Codecov team
This issue is intended to share and collect feedback about the tool. If you have support needs or questions, please see our support page.